chore(deps): bump github.com/golang-jwt/jwt/v4 to v4.5.2 (CVE-2025-30204)

[shahsahil264]

Addresses CVE-2025-30204 (GHSA-mh63-6h87-95cp / GO-2025-3553) and, as a bonus, also clears GO-2024-3250 (improper error handling in ParseWithClaims, fixed in v4.5.1) since v4.5.2 supersedes it.

golang-jwt/jwt/v4 is an indirect/transitive dependency of this repo. Parser.ParseUnverified (the CVE-2025-30204 vulnerable function, which uses strings.Split on untrusted input) is never called by cincinnati-operator's own code.

Proof: govulncheck (before vs. after)

Before (v4.2.0):

Vulnerability #3: GO-2025-3553
    Excessive memory allocation during header parsing in github.com/golang-jwt/jwt
  Module: github.com/golang-jwt/jwt/v4
    Found in: github.com/golang-jwt/jwt/v4@v4.2.0
    Fixed in: github.com/golang-jwt/jwt/v4@v4.5.2

Vulnerability #5: GO-2024-3250
    Improper error handling in ParseWithClaims ...
  Module: github.com/golang-jwt/jwt/v4
    Found in: github.com/golang-jwt/jwt/v4@v4.2.0
    Fixed in: github.com/golang-jwt/jwt/v4@v4.5.1

Summary: affected by 10 vulnerabilities (reachable); 6 vulnerabilities
in imported-but-not-called packages (includes both jwt CVEs above).

After (v4.5.2):

No mention of golang-jwt anywhere in output.
Summary: affected by 10 vulnerabilities (reachable, unchanged — jwt was
never in this bucket); 4 vulnerabilities in imported-but-not-called
packages (down from 6 — both jwt CVEs cleared).

This confirms both CVEs were never reachable from our code (the "affected"/reachable count is identical before and after), and the bump removes them from the dependency tree entirely.

Proof: build / vet / tests

$ go build ./...
BUILD OK

$ go vet ./...
VET OK

$ go test ./controllers/... -v
... (56 test cases across TestEnsureAdditionalTrustedCA, TestEnsureDeployment,
     TestEnsureGraphBuilderService, TestEnsurePolicyEngineService,
     TestEnsurePodDisruptionBudget, TestValidateRouteName,
     TestEnsurePolicyEngineRoute, etc.)
PASS
ok  	github.com/openshift/cincinnati-operator/controllers	0.628s

$ go test ./controllers/... -cover
ok  	github.com/openshift/cincinnati-operator/controllers	0.799s	coverage: 56.0% of statements

This bump is pre-emptive dependency hygiene; the corresponding Jira ticket (OCPBUGS-105272) is being closed as Not-A-Bug since no reachable exploitation path exists in this component.

OCPBUGS-105272

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 649007c2-2cd7-43d7-baae-21dc2ee412b9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shahsahil264
Once this PR has been reviewed and has the lgtm label, please assign lalatendumohanty for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@shahsahil264: This pull request references Jira Issue OCPBUGS-105272, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-105272 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Addresses CVE-2025-30204 (GHSA-mh63-6h87-95cp / GO-2025-3553) and, as a bonus, also clears GO-2024-3250 (improper error handling in ParseWithClaims, fixed in v4.5.1) since v4.5.2 supersedes it.

golang-jwt/jwt/v4 is an indirect/transitive dependency of this repo. Parser.ParseUnverified (the CVE-2025-30204 vulnerable function, which uses strings.Split on untrusted input) is never called by cincinnati-operator's own code.

Proof: govulncheck (before vs. after)

Before (v4.2.0):

Vulnerability #3: GO-2025-3553
   Excessive memory allocation during header parsing in github.com/golang-jwt/jwt
 Module: github.com/golang-jwt/jwt/v4
   Found in: github.com/golang-jwt/jwt/v4@v4.2.0
   Fixed in: github.com/golang-jwt/jwt/v4@v4.5.2

Vulnerability #5: GO-2024-3250
   Improper error handling in ParseWithClaims ...
 Module: github.com/golang-jwt/jwt/v4
   Found in: github.com/golang-jwt/jwt/v4@v4.2.0
   Fixed in: github.com/golang-jwt/jwt/v4@v4.5.1

Summary: affected by 10 vulnerabilities (reachable); 6 vulnerabilities
in imported-but-not-called packages (includes both jwt CVEs above).

After (v4.5.2):

No mention of golang-jwt anywhere in output.
Summary: affected by 10 vulnerabilities (reachable, unchanged — jwt was
never in this bucket); 4 vulnerabilities in imported-but-not-called
packages (down from 6 — both jwt CVEs cleared).

This confirms both CVEs were never reachable from our code (the "affected"/reachable count is identical before and after), and the bump removes them from the dependency tree entirely.

Proof: build / vet / tests

$ go build ./...
BUILD OK

$ go vet ./...
VET OK

$ go test ./controllers/... -v
... (56 test cases across TestEnsureAdditionalTrustedCA, TestEnsureDeployment,
    TestEnsureGraphBuilderService, TestEnsurePolicyEngineService,
    TestEnsurePodDisruptionBudget, TestValidateRouteName,
    TestEnsurePolicyEngineRoute, etc.)
PASS
ok  	github.com/openshift/cincinnati-operator/controllers	0.628s

$ go test ./controllers/... -cover
ok  	github.com/openshift/cincinnati-operator/controllers	0.799s	coverage: 56.0% of statements

This bump is pre-emptive dependency hygiene; the corresponding Jira ticket (OCPBUGS-105272) is being closed as Not-A-Bug since no reachable exploitation path exists in this component.

OCPBUGS-105272

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[shahsahil264]

/jira refresh

[openshift-ci-robot]

@shahsahil264: This pull request references Jira Issue OCPBUGS-105272, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-105272 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[shahsahil264]

/jira refresh

[openshift-ci-robot]

@shahsahil264: This pull request references Jira Issue OCPBUGS-105272, which is invalid:

• expected Jira Issue OCPBUGS-105272 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@shahsahil264: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Addresses CVE-2025-30204 (GHSA-mh63-6h87-95cp / GO-2025-3553) and, as a bonus, also clears GO-2024-3250 (improper error handling in ParseWithClaims, fixed in v4.5.1) since v4.5.2 supersedes it.

golang-jwt/jwt/v4 is an indirect/transitive dependency of this repo. Parser.ParseUnverified (the CVE-2025-30204 vulnerable function, which uses strings.Split on untrusted input) is never called by cincinnati-operator's own code.

Proof: govulncheck (before vs. after)

Before (v4.2.0):

Vulnerability #3: GO-2025-3553
   Excessive memory allocation during header parsing in github.com/golang-jwt/jwt
 Module: github.com/golang-jwt/jwt/v4
   Found in: github.com/golang-jwt/jwt/v4@v4.2.0
   Fixed in: github.com/golang-jwt/jwt/v4@v4.5.2

Vulnerability #5: GO-2024-3250
   Improper error handling in ParseWithClaims ...
 Module: github.com/golang-jwt/jwt/v4
   Found in: github.com/golang-jwt/jwt/v4@v4.2.0
   Fixed in: github.com/golang-jwt/jwt/v4@v4.5.1

Summary: affected by 10 vulnerabilities (reachable); 6 vulnerabilities
in imported-but-not-called packages (includes both jwt CVEs above).

After (v4.5.2):

No mention of golang-jwt anywhere in output.
Summary: affected by 10 vulnerabilities (reachable, unchanged — jwt was
never in this bucket); 4 vulnerabilities in imported-but-not-called
packages (down from 6 — both jwt CVEs cleared).

This confirms both CVEs were never reachable from our code (the "affected"/reachable count is identical before and after), and the bump removes them from the dependency tree entirely.

Proof: build / vet / tests

$ go build ./...
BUILD OK

$ go vet ./...
VET OK

$ go test ./controllers/... -v
... (56 test cases across TestEnsureAdditionalTrustedCA, TestEnsureDeployment,
    TestEnsureGraphBuilderService, TestEnsurePolicyEngineService,
    TestEnsurePodDisruptionBudget, TestValidateRouteName,
    TestEnsurePolicyEngineRoute, etc.)
PASS
ok  	github.com/openshift/cincinnati-operator/controllers	0.628s

$ go test ./controllers/... -cover
ok  	github.com/openshift/cincinnati-operator/controllers	0.799s	coverage: 56.0% of statements

This bump is pre-emptive dependency hygiene; the corresponding Jira ticket (OCPBUGS-105272) is being closed as Not-A-Bug since no reachable exploitation path exists in this component.

OCPBUGS-105272

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[shahsahil264]

#274