Skip to content

fix: select only the clicked space when opening admin space details #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexAndBear merged 2 commits into from
Sep 30, 2026
Merged

fix: select only the clicked space when opening admin space details #3487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6129229
fix: select only the clicked space when opening admin space details
AlexAndBear Sep 29, 2026
c227e25
refactor: reuse row click selection logic for space details
AlexAndBear Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/web-app-admin-settings/src/components/Spaces/SpacesList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@ const spaceDetailsLabel = computed(() => {
return $gettext('Show details')
})
const showDetailsForSpace = (space: SpaceResource) => {
unselectAllSpaces()
selectSpace(space)
openSideBar()
}
Expand Down
23 changes: 21 additions & 2 deletions packages/web-app-admin-settings/tests/unit/components/Spaces/SpacesList.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,18 @@ describe('SpacesList', () => {
await wrapper.find('.spaces-table-btn-details').trigger('click')
expect(openSideBar).toHaveBeenCalled()
})
it.each([
{ description: 'another space', selectedSpaces: [spaceMocks[1]] },
{ description: 'the same space', selectedSpaces: [spaceMocks[0]] }
])(
'selects only the clicked space on details button click if $description is selected',
async ({ selectedSpaces }) => {
const { wrapper } = getWrapper({ spaces: spaceMocks, selectedSpaces, stubActions: false })
await wrapper.find('.spaces-table-btn-details').trigger('click')
const { selectedSpaces: newSelection } = useSpaceSettingsStore()
expect(newSelection).toEqual([spaceMocks[0]])
}
)
describe('toggle selection', () => {
describe('selectSpaces method', () => {
it('selects all spaces', () => {
Expand Down Expand Up @@ -177,8 +189,14 @@ describe('SpacesList', () => {
function getWrapper({
mountType = mount,
spaces = [],
selectedSpaces = []
}: { mountType?: typeof mount; spaces?: SpaceResource[]; selectedSpaces?: SpaceResource[] } = {}) {
selectedSpaces = [],
stubActions = true
}: {
mountType?: typeof mount
spaces?: SpaceResource[]
selectedSpaces?: SpaceResource[]
stubActions?: boolean
} = {}) {
vi.mocked(queryItemAsString).mockImplementationOnce(() => '1')
vi.mocked(queryItemAsString).mockImplementationOnce(() => '100')
const mocks = defaultComponentMocks()
Expand All @@ -193,6 +211,7 @@ function getWrapper({
plugins: [
...defaultPlugins({
piniaOptions: {
stubActions,
spaceSettingsStore: { spaces, selectedSpaces }
}
})
Expand Down
Loading