Skip to content

fix: select only the clicked space when opening admin space details - #3487

Merged
AlexAndBear merged 2 commits into
mainfrom
fix/admin-spaces-details-selection
Sep 30, 2026
Merged

AlexAndBear merged 2 commits into
mainfrom
fix/admin-spaces-details-selection

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

In the admin settings Spaces list, the "Show details" (info) button toggled the space in the current selection instead of selecting only that space:

  • With a space selected, clicking the info button of another space added it to the selection. The details panel then showed "2 spaces selected".
  • With a space selected, clicking the info button of the same space deselected it. The details panel then showed "Select a space to view details".

The button stops click propagation, so the row click handler that normally resets the selection never ran. The details button now sets the selection to only the clicked space before opening the sidebar. This matches the behavior of the Users and Groups lists.

Related Issue

  • Fixes <issue_link>

How Has This Been Tested?

  • test environment: local dev setup (Vite dev server + OpenCloud backend via docker-compose), Chromium; Vitest
  • test case 1: Spaces: select "New space", click info of "space-5": only "space-5" is selected and its details are shown
  • test case 2: Spaces: click info of the already selected space again: it stays selected and its details are shown
  • test case 3: Users: select one user, click info of another user: only the clicked user is selected (unchanged)
  • test case 4: new unit tests for both cases in SpacesList.spec.ts, which fail without the fix

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit b70e6c2 into main Sep 30, 2026
31 checks passed
@AlexAndBear
AlexAndBear deleted the fix/admin-spaces-details-selection branch September 30, 2026 07:44
@openclouders openclouders mentioned this pull request Sep 30, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants