Repository navigation
fix(yjs): scope the recovery grant to the room - #3437
Merged
JammingBen merged 1 commit intoSep 30, 2026
Merged
Conversation
2 tasks done
JammingBen
force-pushed
the
fix/yjs-room-scoped-recovery-grant
branch
from
September 23, 2026 14:03
01ab599 to
cc1f83d
Compare
JammingBen
force-pushed
the
fix/yjs-room-scoped-recovery-grant
branch
from
September 30, 2026 06:55
cc1f83d to
e99f23f
Compare
JammingBen
marked this pull request as ready for review
September 30, 2026 08:23
AlexAndBear
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #3433.
Change the recovery grant from being per-etag to exactly one per room. This prevents 2 peers from both getting a grant within the same room.
On top of that, this change allows for more generic grants, which is needed for e.g. #3395.