Repository navigation
fix(yjs): let the server grant stale recovery to one client - #3433
Merged
Merged
Conversation
JammingBen
force-pushed
the
fix/yjs-recovery-grant
branch
from
September 23, 2026 09:18
7178d7a to
72a7ea1
Compare
JammingBen
force-pushed
the
fix/yjs-recovery-grant
branch
3 times, most recently
from
September 23, 2026 12:07
15585ec to
ff526b1
Compare
JammingBen
force-pushed
the
fix/yjs-recovery-grant
branch
from
September 23, 2026 12:52
ff526b1 to
86512ec
Compare
This was referenced Sep 23, 2026
Replaces the recoveryClientId election and its 150 ms wait with a per-etag grant from the Yjs server, generalized from the seed grant. The meta observer now uses transaction.local instead of own-origin constants.
JammingBen
force-pushed
the
fix/yjs-recovery-grant
branch
from
September 30, 2026 06:32
86512ec to
42806d5
Compare
JammingBen
force-pushed
the
fix/yjs-recovery-grant
branch
from
September 30, 2026 06:54
42806d5 to
8cf4d25
Compare
JammingBen
marked this pull request as ready for review
September 30, 2026 07:24
AlexAndBear
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the client-side
recoveryClientIdelection and its 150 ms wait with a per-etag grant from the Yjs server. Just like with the seeding, letting the server decide who can recover is more robust than handling this client-side. The meta observer now usestransaction.localinstead of own-origin constants.The client still uses the old seeding grant to ensure backwards compatibility. We plan to remove it eventually, see #3436. The same goes for the old recovery mechanism, which is also kept in the client. Most of this should be encapsulated in 86512ec.
fixes #3429
fixes #3132
refs #3428