Skip to content

fix(cli): detect storage driver from storage path in revisions and trash commands - #3776

Merged
v-scharf merged 1 commit into
mainfrom
fix/cli-detect-storage-driver
Oct 23, 2026
Merged

v-scharf merged 1 commit into
mainfrom
fix/cli-detect-storage-driver

Conversation

@v-scharf

Copy link
Copy Markdown
Contributor

Fixes #3774

revisions purge and trash purge-empty-dirs relied on STORAGE_USERS_DRIVER, which is often not set in the admin shell (default posix), so decomposed storages reported "no nodes found" / "no trash found".

The layout is now detected from the storage path (spaces/*/*/nodes → decomposed, */*/.oc-nodes → posix), falling back to the configured driver for empty storages.

@v-scharf
v-scharf requested a review from maki5 October 21, 2026 12:53
@codacy-production

codacy-production Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 12 complexity

Metric Results
Complexity 12

View in Codacy

🟢 Coverage 92.31% diff coverage · +0.04% coverage variation

Metric Results
Coverage variation ✅ +0.04% coverage variation (-1.00%)
Diff coverage ✅ 92.31% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8acaef2) 92534 23924 25.85%
Head commit (9eaa37d) 92558 (+24) 23971 (+47) 25.90% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3776) 26 24 92.31%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@v-scharf
v-scharf merged commit ef9c6e7 into main Oct 23, 2026
59 of 62 checks passed
@v-scharf
v-scharf deleted the fix/cli-detect-storage-driver branch October 23, 2026 19:38
@openclouders openclouders mentioned this pull request Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenCloud 8.1.0 rolling: revisions purge and trash purge-empty-dirs, no nodes found, no trash found

2 participants