Repository navigation
chore(deps-dev): bump the development group with 2 updates - #1012
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the development group with 2 updates: [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `@vitest/coverage-v8` from 5.0.4 to 5.0.5 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.5/packages/coverage-v8) Updates `vitest` from 5.0.4 to 5.0.5 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.5/packages/vitest) --- updated-dependencies: - dependency-name: "@vitest/coverage-v8" dependency-version: 5.0.5 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development - dependency-name: vitest dependency-version: 5.0.5 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs changes before merge. What this changesUpdates Vitest and its V8 coverage provider from 5.0.4 to 5.0.5, including matching lockfile dependencies. Example: Run pnpm test on Windows with the updated lockfile.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Regression provenancePossible regression — probable (reviewed change; failure trace). No predecessor PR is attributed. Merge readiness⛔ Needs changes before merge - 1 item remains Keep this PR open: main still uses Vitest 5.0.4, and the update introduces a Windows test-selection regression that must be repaired before merge. Priority: P2 Before merge
Findings
Agent review detailsHow this fits togetherVitest executes fs-safe's development and CI test suites; its coverage provider collects coverage without becoming a shipped filesystem runtime dependency. flowchart LR
A[Package manifest] --> B[pnpm lockfile]
B --> C[Vitest runner]
C --> D[Platform test guards]
D --> E[Filesystem test suites]
E --> F[CI results and coverage]
Technical reviewBest possible solution: Keep the dependency update and combine the Windows and root-user exclusions in the three affected path-prefix test declarations. Do we have a high-confidence way to reproduce the issue? The upstream runner change and existing chained guards explain the exact-head Windows annotations; no target code was executed locally. Is this the best way to solve the issue? Updating the matched Vitest packages is reasonable, provided the existing tests express their combined exclusion explicitly. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 5147654024a7. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceAcceptance criteria:
What I checked:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 19, 2026, 1:39 PM ET / 17:39 UTC. |
Update Vitest and coverage to 5.0.5, emnapi runtime to 2.0.0-beta.2, and CodeQL to 4.39.0 after the two-day dependency cooldown. Combine the POSIX and uid skip conditions: Vitest 5.0.5 skipIf(false) clears prior skip state, which exposed Unix permission assertions to Windows. Keep the same permission checks for unprivileged POSIX users. Consolidates #1012, #1013 and #1014. Validation: full pnpm check on Crabbox (14,335 tests), focused POSIX path permission tests, actionlint, and independent review without actionable findings. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Consolidated into #1015, including the required Vitest 5.0.5 test-gating adaptation. The combined update has passed the full check and cross-platform CI. Thanks for the update. |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the development group with 2 updates: @vitest/coverage-v8 and vitest.
Updates
@vitest/coverage-v8from 5.0.4 to 5.0.5Release notes
Sourced from @vitest/coverage-v8's releases.
Commits
7a825dbchore: release v5.0.5 (#11609)Updates
vitestfrom 5.0.4 to 5.0.5Release notes
Sourced from vitest's releases.
Commits
7a825dbchore: release v5.0.5 (#11609)6621a72fix: abort all running tests on cancel (#11606)e9c3d72fix: release mocks of finished test files (#11607)8dd67c2fix(browser): run global setup once with instances (#11596)6c5a447fix: run hook cleanups when a later hook fails (#11605)9697b38fix: keep the import frame in native loader errors (#11599)6498b66fix(browser): wait 30s for the browser to close (#11601)f161e6dfix(browser): drop late connections of closed sessions (#11600)fe86a64fix: skip builtin loading in async leak detector (#11598)6ae8e89fix(reporter): end reason'failed'on worker crash (#11568)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions