Skip to content

chore(deps-dev): bump the development group with 2 updates - #1012

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/development-17913b848a
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/development-17913b848a

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 19, 2026

Copy link
Copy Markdown
Contributor

Bumps the development group with 2 updates: @vitest/coverage-v8 and vitest.

Updates @vitest/coverage-v8 from 5.0.4 to 5.0.5

Release notes

Sourced from @​vitest/coverage-v8's releases.

v5.0.5

   🐞 Bug Fixes

    View changes on GitHub
Commits

Updates vitest from 5.0.4 to 5.0.5

Release notes

Sourced from vitest's releases.

v5.0.5

   🐞 Bug Fixes

    View changes on GitHub
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the development group with 2 updates: [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest).


Updates `@vitest/coverage-v8` from 5.0.4 to 5.0.5
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md)
- [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.5/packages/coverage-v8)

Updates `vitest` from 5.0.4 to 5.0.5
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md)
- [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.5/packages/vitest)

---
updated-dependencies:
- dependency-name: "@vitest/coverage-v8"
  dependency-version: 5.0.5
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development
- dependency-name: vitest
  dependency-version: 5.0.5
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot requested a review from a team as a code owner October 19, 2026 17:25
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Oct 19, 2026
@clawsweeper

clawsweeper Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Oct 19, 2026
@clawsweeper

clawsweeper Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs changes before merge.

What this changes

Updates Vitest and its V8 coverage provider from 5.0.4 to 5.0.5, including matching lockfile dependencies.

Example: Run pnpm test on Windows with the updated lockfile.

  • Before: Vitest 5.0.4 skips the POSIX-only path-prefix permission cases.
  • After: Vitest 5.0.5 runs ten previously skipped cases, causing permission and path-separator assertions to fail.

Review scores

Measure Result What it means
Overall readiness 🦪 silver shellfish (2/6) The dependency update has maintenance value, but its Windows guard incompatibility causes reproducible CI failures.
Proof confidence 🌊 off-meta tidepool Not applicable: This Dependabot-authored maintenance PR is outside the ordinary contributor proof gate; CI annotations establish the introduced test-selection defect without proving a repaired result.
Patch quality 🦪 silver shellfish (2/6) 1 actionable review finding remain.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Contributors rely on compatible test and coverage tooling to validate filesystem safety across platforms.
Reason: The matched patch update follows established dependency maintenance and stays within development tooling; repository policy correctly requires no maintenance-only changelog entry.

Regression provenance

Possible regression — probable (reviewed change; failure trace). No predecessor PR is attributed.

Merge readiness

⛔ Needs changes before merge - 1 item remains

Keep this PR open: main still uses Vitest 5.0.4, and the update introduces a Windows test-selection regression that must be repaired before merge.

Priority: P2
Reviewed head: e9ddc80137171aac19641293380e606d82d43381

Before merge

  • Preserve Windows exclusions when upgrading Vitest (P2) - Vitest 5.0.5 deliberately makes skipIf(false) set skip:false, overriding an earlier chained skip. On Windows, itPosix starts skipped, but process.getuid?.() === 0 is false, so the declarations at test/path-prefix.test.ts:255, 277, and 296 become runnable. Their ten POSIX permission and separator cases then fail, exactly matching the Node 22/24/26 Windows and Windows coverage annotations. Combine the Windows and root-user predicates into one exclusion condition in those declarations so the update preserves platform selection.

Findings

  • [P2] Preserve Windows exclusions when upgrading Vitest — pnpm-lock.yaml:210
Agent review details

How this fits together

Vitest executes fs-safe's development and CI test suites; its coverage provider collects coverage without becoming a shipped filesystem runtime dependency.

flowchart LR
  A[Package manifest] --> B[pnpm lockfile]
  B --> C[Vitest runner]
  C --> D[Platform test guards]
  D --> E[Filesystem test suites]
  E --> F[CI results and coverage]
Loading

Technical review

Best possible solution:

Keep the dependency update and combine the Windows and root-user exclusions in the three affected path-prefix test declarations.

Do we have a high-confidence way to reproduce the issue?

The upstream runner change and existing chained guards explain the exact-head Windows annotations; no target code was executed locally.

Is this the best way to solve the issue?

Updating the matched Vitest packages is reasonable, provided the existing tests express their combined exclusion explicitly.

Full review comments:

  • [P2] Preserve Windows exclusions when upgrading Vitest — pnpm-lock.yaml:210
    Vitest 5.0.5 deliberately makes skipIf(false) set skip:false, overriding an earlier chained skip. On Windows, itPosix starts skipped, but process.getuid?.() === 0 is false, so the declarations at test/path-prefix.test.ts:255, 277, and 296 become runnable. Their ten POSIX permission and separator cases then fail, exactly matching the Node 22/24/26 Windows and Windows coverage annotations. Combine the Windows and root-user predicates into one exclusion condition in those declarations so the update preserves platform selection.
    Confidence: 0.99

Overall correctness: patch is incorrect
Overall confidence: 0.99

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 5147654024a7.

Provenance checked

  • Vitest and V8 coverage version alignment keeps the original intent (c8b1b73: The previous tooling refresh deliberately updated Vitest and coverage together while preserving runtime and cooldown policy.)

Testing

Proof path: unit tests only.

Security

None.

Evidence

Acceptance criteria:

  • On Windows: pnpm test test/path-prefix.test.ts
  • On non-root POSIX: pnpm test test/path-prefix.test.ts
  • On root POSIX: pnpm test test/path-prefix.test.ts
  • pnpm check
  • git diff --check

What I checked:

Labels

Label changes:

  • add P2: The update breaks Windows development and CI validation without changing the shipped filesystem API.
  • add merge-risk: 🚨 automation: The dependency changes test-selection behavior, causing ten POSIX-only cases to execute on Windows and fail four validation jobs.
  • add rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🌊 off-meta tidepool and patch quality is 🦪 silver shellfish.
  • add status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Label justifications:

  • P2: The update breaks Windows development and CI validation without changing the shipped filesystem API.
  • merge-risk: 🚨 automation: The dependency changes test-selection behavior, causing ten POSIX-only cases to execute on Windows and fail four validation jobs.
  • rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🌊 off-meta tidepool and patch quality is 🦪 silver shellfish.
  • status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 19, 2026, 1:39 PM ET / 17:39 UTC.

steipete added a commit that referenced this pull request Oct 19, 2026
Update Vitest and coverage to 5.0.5, emnapi runtime to 2.0.0-beta.2, and
CodeQL to 4.39.0 after the two-day dependency cooldown.

Combine the POSIX and uid skip conditions: Vitest 5.0.5 skipIf(false)
clears prior skip state, which exposed Unix permission assertions to Windows.
Keep the same permission checks for unprivileged POSIX users.

Consolidates #1012, #1013 and #1014.

Validation: full pnpm check on Crabbox (14,335 tests), focused POSIX path
permission tests, actionlint, and independent review without actionable findings.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@steipete

Copy link
Copy Markdown
Contributor

Consolidated into #1015, including the required Vitest 5.0.5 test-gating adaptation. The combined update has passed the full check and cross-platform CI. Thanks for the update.

@steipete steipete closed this Oct 19, 2026
@dependabot @github

dependabot Bot commented on behalf of github Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/development-17913b848a branch October 19, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. P2 Normal priority bug or improvement with limited blast radius. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant