fix(ci): run behavioral checks for authored plugin Markdown - #730
mldangelo-oai wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 514fa9ea60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| while IFS= read -r -d '' path; do | ||
| changed=true | ||
| if [[ "$path" != *.md || | ||
| "$path" == plugins/codex-security/* || |
There was a problem hiding this comment.
When a PR changes only plugins/codex-security/.../*.md, this condition now selects full, so the Check Markdown formatting step at lines 102–115 is skipped. The full-mode formatter is pnpm --dir sdk/typescript run format; pnpm help run defines --dir as “Change to directory
**/*.md glob cannot reach the authored files under ../../plugins (while _bundled_plugin/ is explicitly ignored). Consequently, a Prettier-only formatting error in an authored SKILL.md that previously failed reduced CI can now pass all full-mode checks; run the changed-file Markdown formatter in full mode as well, or explicitly include the authored plugin Markdown in a full-mode formatting step.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Closing as a duplicate of #729, which includes the same classifier fix and regression coverage. |
1 participant
Summary
Changes to shipped plugin skills could take the Markdown-only CI path and skip the behavioral tests that validate those skills. Authored plugin Markdown now selects full CI, just like the generated plugin payload.
Changes
plugins/codex-security/**from the Markdown-only shortcut.SKILL.mdchange.Testing
bun test --timeout 30000 tests-ts/release-automation.test.ts: 281 passed, 0 failed with Bun 1.3.14.prettier --check tests-ts/release-automation.test.ts: passed.git diff --check: passed.Risk and rollout
This expands CI execution for Markdown changes under the authored plugin directory. It does not change runtime behavior or skip any existing check. No migration or configuration change is needed.
Public disclosure review