Skip to content

ci: run full checks for authored plugin Markdown - #729

Merged
mldangelo-oai merged 2 commits into
mainfrom
codex/ci-plugin-markdown
Aug 29, 2026
Merged

mldangelo-oai merged 2 commits into
mainfrom
codex/ci-plugin-markdown

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Markdown in the authored plugin tree controls scan behavior, but node-ci classified those changes as documentation-only. Its exception covered the generated _bundled_plugin path, allowing authored skill and reference changes to skip the behavioral tests and package checks.

Changes

  • Run full CI for changes under plugins/codex-security, including Markdown.
  • Preserve the existing generated-plugin exception and the fast path for ordinary documentation.
  • Keep changed-file formatting and its setup steps enabled for Markdown-only PRs, independently of whether they need full CI.
  • Extend the existing shell-based classification tests with authored skill and reference cases, and evaluate the actual formatting-step conditions for every case.

Testing

  • Both new classification cases failed before the workflow fix; all 9 classification cases pass afterward.
  • Reproduced the formatting-check regression found in review, then verified that all 9 cases select both CI and formatter setup correctly. The actual formatting step rejects an unformatted synthetic plugin skill and passes after formatting while selecting full CI.
  • Targeted CI, formatter, and required-context regressions: 11 passed, 0 failed.
  • pnpm run types, pnpm run format, workflow formatting, and git diff --check passed.
  • Full SDK suite on the final code with seeds 12345 and 3808443279: 2,057 passed, 36 skipped, and 0 failed in each run. These runs used process inspection access, which the process-group test requires; initial sandboxed runs had blocked ps.

Risk and rollout

Plugin Markdown changes will now run the existing full CI matrix and use more CI time. Ordinary documentation still uses the reduced checks. This does not change runtime behavior, dependencies, required check names, or release behavior.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-29T00:59:15.907237Z 330b6f8 Manual request
🔒 Security Review ✅ Completed 2026-08-29T00:32:38.158195Z b403b3a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b403b3a0be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/node-ci.yml Outdated
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review commit 330b6f8cb9cc7bc799ed98e27225e438320c9139, including the separate Markdown formatting decision and its setup conditions. The earlier formatting regression is fixed, and both full SDK runs passed with 2,057 tests each.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex security review

Please review commit 330b6f8cb9cc7bc799ed98e27225e438320c9139, especially preserving full checks for authored plugin Markdown while retaining the changed-file formatting gate.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 330b6f8cb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex security review

Please review commit 330b6f8cb9cc7bc799ed98e27225e438320c9139, especially preserving full checks for authored plugin Markdown while retaining the changed-file formatting gate.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 330b6f8cb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai
mldangelo-oai merged commit 956fd89 into main Aug 29, 2026
40 of 67 checks passed
@mldangelo-oai
mldangelo-oai deleted the codex/ci-plugin-markdown branch August 29, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants