Skip to content

add code review checklist #12037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feerrenrut merged 2 commits into from
Feb 5, 2021
Merged

add code review checklist #12037

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1bb29e
add code review checklist
feerrenrut Feb 5, 2021
a876e1b
Update .github/PULL_REQUEST_TEMPLATE.md
feerrenrut Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,24 @@ Please also note that the NVDA project has a Citizen and Contributor Code of Con

### Description of how this pull request fixes the issue:

### Testing performed:
### Testing strategy:

### Known issues with pull request:

### Change log entry:

Section: New features, Changes, Bug fixes

### Code Review Checklist:

This checklist is a reminder of things commonly forgotten in a new PR.
Please do a self-review to check these items.
Reviewers will not approve the PR until these are met.

- [ ] Pull Request description is up to date.
- [ ] Unit tests.
- [ ] System (end to end) tests.
- [ ] Manual tests.
- [ ] User Documentation.
- [ ] Change log entry.
- [ ] Context sensitive help for GUI changes.