Repository navigation
add code review checklist - #12037
Merged
Merged
Conversation
LeonarddeR
previously approved these changes
Feb 5, 2021
Co-authored-by: Leonard de Ruijter <leonardder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Authors of changes for NVDA and reviewers alike often forget several "small" things which accumulate causing issues for the project.
Description of how this pull request fixes the issue:
Add a checklist to the PR template for authors and reviewers to run through to ensure nothing is missed.
In addition, the following will be added to the end of https://github.com/nvaccess/nvda/wiki/Github-pull-request-template-explanation-and-examples
Testing strategy:
N/A
Known issues with pull request:
None
Change log entry:
None
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Please do a self-review to check these items.
Reviewers will not approve the PR until this are met.