fix: emit synthetic load/error events on initial hydration - #842
Merged
Conversation
✅ Deploy Preview for nuxt-image-v1 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
danielroe
marked this pull request as ready for review
May 31, 2023 20:58
pi0
reviewed
Jun 6, 2023
pi0
approved these changes
Jun 6, 2023
Merged
|
wiii! |
|
@error is still not working |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #682
resolves #412
This PR emits load/error events on initial hydration for better DX if the load/error event has already occurred before hydration.