Skip to content

chore: fix test cases & clean up docs#62

Merged
Lexpeartha merged 3 commits into
mainfrom
clean-up
Sep 12, 2022
Merged

chore: fix test cases & clean up docs#62
Lexpeartha merged 3 commits into
mainfrom
clean-up

Conversation

@Lexpeartha

Copy link
Copy Markdown
Collaborator

PR to clean up where it's possible, and to fix failing CI

@Lexpeartha Lexpeartha self-assigned this Sep 11, 2022
@vercel

vercel Bot commented Sep 11, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nuxt-ionic ✅ Ready (Inspect) Visit Preview Sep 12, 2022 at 8:27AM (UTC)

@azrikahar

Copy link
Copy Markdown
Contributor

Hi, random tangent here but should the test ci be stopped manually first? It seems like it's somehow stuck & keeps running instead of stopping itself.

@Lexpeartha

Copy link
Copy Markdown
Collaborator Author

image
Looking into it, but on my local machine everything works fine

@Lexpeartha

Lexpeartha commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator Author

Alright, it seems that newer versions of playwright require additional step to set up browsers appropriate to OS it's running on

@Lexpeartha

Lexpeartha commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator Author

@danielroe One question, in other PR I saw you pinned nuxt version to rc 8, is there a particular reason for that? Should I update it, or leave it like this?

Also Socket Security: Project Report seems to be stuck as well

@Lexpeartha Lexpeartha marked this pull request as draft September 12, 2022 08:38
@azrikahar

Copy link
Copy Markdown
Contributor

Alright, it seems that newer versions of playwright require additional step to set up browsers appropriate to OS it's running on

Interesting! Glad it's resolved now 🚀

@danielroe

Copy link
Copy Markdown
Collaborator

Yes, we'll leave it pinned for docs at the moment, unless you'd like to tackle upgrading docus... you can see nitrojs/nitro#365 as an example...

@Lexpeartha Lexpeartha marked this pull request as ready for review September 12, 2022 10:07
@Lexpeartha

Copy link
Copy Markdown
Collaborator Author

unless you'd like to tackle upgrading docus... you can see unjs/nitro#365 as an example...

I think we can merge this PR, and I'll start migration in new one 👌🏽

@Lexpeartha Lexpeartha merged commit f44e47f into main Sep 12, 2022
@Lexpeartha Lexpeartha deleted the clean-up branch September 12, 2022 10:08
@github-actions github-actions Bot mentioned this pull request Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants