lib: add SafeArray to primordials and use it for FreeList#36600
Open
ExE-Boss wants to merge 1 commit intonodejs:mainfrom
Open
lib: add SafeArray to primordials and use it for FreeList#36600ExE-Boss wants to merge 1 commit intonodejs:mainfrom
SafeArray to primordials and use it for FreeList#36600ExE-Boss wants to merge 1 commit intonodejs:mainfrom
Conversation
2 tasks
Member
|
Run Benchmark on my computer, seems the performance issues still exists. |
Contributor
Contributor
Author
|
Looks like the benchmark CI crashed: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/783/console |
aduh95
requested changes
Dec 22, 2020
Contributor
aduh95
left a comment
There was a problem hiding this comment.
Benchmark confirmed very poor performance results…
confidence improvement accuracy (*) (**) (***)
misc/freelist.js n=100000 *** -91.36 % ±3.89% ±5.24% ±6.96%
Contributor
Author
|
If I had to guess, I’d say V8 is doing some inlining shenanigans when it detects a By inlining the methods in #37649, I hope to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #36304 (comment)
Refs: #36565
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes