lib: refactor to use more primordials in internal/freelist.js#36565
Closed
Lxxyx wants to merge 1 commit intonodejs:mainfrom
Closed
lib: refactor to use more primordials in internal/freelist.js#36565Lxxyx wants to merge 1 commit intonodejs:mainfrom
Lxxyx wants to merge 1 commit intonodejs:mainfrom
Conversation
Contributor
|
The benchmark CI regression is quite significant: |
2 tasks
Member
Author
freelist is simple data structure, so refactoring to primordials causes a significant performance regression. I tried some solutions, but they didn't work. Do you all have any ideas about this issue? @aduh95 |
Contributor
|
I’m going to try implementing |
ExE-Boss
added a commit
to ExE-Boss/node
that referenced
this pull request
Dec 22, 2020
3 tasks
Contributor
|
I’ve now opened #36600, which implements |
Member
Author
|
Close due to long-term inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference
The file is used here:
node/lib/_http_common.js
Line 34 in b49145f
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes