Conversation
icewind1991
added
2. developing
icewind1991
force-pushed
the
openstack
branch
from
ec57822 to
fa62205
Compare
Codecov Report
@@ Coverage Diff @@
## master #8314 +/- ##
===========================================
+ Coverage 51.72% 51.82% +0.1%
+ Complexity 25380 25364 -16
===========================================
Files 1600 1601 +1
Lines 95089 95025 -64
Branches 1377 1377
===========================================
+ Hits 49184 49246 +62
+ Misses 45905 45779 -126
|
icewind1991
force-pushed
the
openstack
branch
6 times, most recently
from
fdebb9c to
5db961d
Compare
icewind1991
added
3. to review
2 tasks
Member
|
Conflicts :/ |
icewind1991
force-pushed
the
openstack
branch
from
5db961d to
72d8609
Compare
Member
Author
|
All rebased |
icewind1991
force-pushed
the
openstack
branch
from
72d8609 to
c8f1fb4
Compare
MorrisJobke
approved these changes
Feb 16, 2018
icewind1991
force-pushed
the
openstack
branch
from
c8f1fb4 to
8bb0e17
Compare
Member
|
I rebased as I want the swift tests to pass here :P |
Member
Author
|
The swift docker image is being a PITA, I'm trying to get it more reliable |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
force-pushed
the
openstack
branch
3 times, most recently
from
ce72206 to
d5f5c84
Compare
* Also create a test file so we know for sure it all works Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
approved these changes
Feb 19, 2018
Member
Member
|
@MorrisJobke we don't run swift tests on stable13 |
MorrisJobke
reviewed
Jan 9, 2019
|
|
||
| // cleanup | ||
| if ($this->unlink($path1) === false) { | ||
| throw new \Exception('failed to remove original'); |
Member
There was a problem hiding this comment.
The two lines after this are unreachable 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for enabling v3 authentication