update guzzlehttp/guzzle to 6.3.0#8259
Merged
MorrisJobke merged 6 commits intomasterfrom Feb 14, 2018
Merged
Conversation
Member
|
CI fails |
Codecov Report
@@ Coverage Diff @@
## master #8259 +/- ##
============================================
- Coverage 51.76% 51.69% -0.07%
- Complexity 25385 25391 +6
============================================
Files 1599 1599
Lines 95102 95119 +17
Branches 1376 1376
============================================
- Hits 49227 49171 -56
- Misses 45875 45948 +73
|
icewind1991
force-pushed
the
guzzle6
branch
3 times, most recently
from
92906ab to
83ada34
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
changed the title
Member
Author
|
ci looks happy, review time |
rullzer
approved these changes
Feb 12, 2018
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Seems to all still work as far as I can tell.
| * @param ResponseInterface $response | ||
| */ | ||
| private function extracRequestTokenFromResponse(ResponseInterface $response) { | ||
| private function extracRequestTokenFromResponse(\Psr\Http\Message\ResponseInterface $response) { |
Member
There was a problem hiding this comment.
Either this is not needed, or the docs is now wrong
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
added
3. to review
Member
|
All ready to merge? |
2 tasks
MorrisJobke
approved these changes
Feb 14, 2018
This was referenced May 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires:
Needed for updating the openstack sdk
Fixes https://github.com/nextcloud/3rdparty/issues/49