Merged
Conversation
Member
MorrisJobke
commented
Mar 2, 2017
MorrisJobke
commented
- followup to Change language code from fi_FI to fi #1377
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen to be a potential reviewer. |
| * {@inheritdoc} | ||
| */ | ||
| public function run(IOutput $output) { | ||
| if ($this->config->getAppValue('core', 'languageCodesUpdatedNC12', false)) { |
Member
There was a problem hiding this comment.
just compare the version number instead of introducing a new config that will then be around forever?
Member
Author
There was a problem hiding this comment.
We also do this in other NC11 repair steps 🙈
Maybe we namespace them to easily clean up. But I will change this one to the version number too.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
run-lang-update-only-once
branch
from
18c733b to
0b12eb0
Compare
rullzer
approved these changes
Mar 3, 2017
nickvergessen
requested changes
Mar 3, 2017
|
|
||
| public function testSecondRun() { | ||
| /** @var IOutput|\PHPUnit_Framework_MockObject_MockObject $outputMock */ | ||
| $outputMock = $this->createMock(IOutput::class); |
Member
There was a problem hiding this comment.
Add something like:
$outputMock->expects($this->never())
->method('info');Otherwise this test always passes, even when I raise the version number
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
approved these changes
Mar 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.