Change language code from fi_FI to fi

[MorrisJobke]

• then the language is not that specific and get also matched for fi
• fallback from fi_FI to fi is supported - the other way around not
• contains repair script
• contains tests for repair script
• fixes Too specific locale fi_FI #869

@kohtala @rullzer

I will also update all the transifex files in all apps to match the settings here.

[mention-bot]

@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @PVince81 and @nickvergessen to be potential reviewers

[rullzer]

• Updated autoloader.

👍

[kohtala]

Hi. Thanks for working on this.

In the #869 I had listed 18th Aug that this same problem seems to be with several other languages as well. I prepared the list for other languages for lang_map as af_zA:af, am_ET:am, bg_BG:bg, cs_CZ:cs, cy_GB:cy, fy_NL:fy, hu_HU:hu, ka_GE:ka, ku_IQ:ku, lt_LT:lt, ms_MY:ms, mt_MT:mt, my_MM:my, nb_NO:nb, nn_NO:nn, si_LK:si, sk_SK:sk, sw_KE:sw, tg_TJ:tg, th_TH:th, tl_PH:tl, ur_PK:ur.

Also, would you think /l10n/rm-old.sh, /settings/languageCodes.php and /settings/personal.php need an update as well?

[MorrisJobke]

Also, would you think /l10n/rm-old.sh, /settings/languageCodes.php and /settings/personal.php need an update as well?

Thanks. I will check this.

[nickvergessen]

does every app need this change? or is it good enough, once per project?

[MorrisJobke]

Every app needs this, but I will do that once this is in.

[LukasReschke]

@MorrisJobke Is this still interesting? If not we should probably close this 😉

[MorrisJobke]

@MorrisJobke Is this still interesting? If not we should probably close this 😉

Yes. One needs to write the migration code to change the users language to fi if it was fi_FI.

[LukasReschke]

Yes. One needs to write the migration code to change the users language to fi if it was fi_FI.

❓

[blizzz]

Can be mostly guttenberged from DAV migration, see https://github.com/nextcloud/server/blob/master/apps/dav/lib/Migration/ValueFixInsert.php and https://github.com/nextcloud/server/blob/master/apps/dav/lib/Migration/ValueFix.php

Basically it registers a background job per (known) user and applies some logic and the actual implementation.

[nickvergessen]

Or simply run a query update oc_preferences set value =“fi“ where value = “fi_FI“ and key =“lang“ and app =“settings“ ? No need to loop over users or create a background job....

[blizzz]

@nickvergessen ah, of course, this is most reasonably :)

[MorrisJobke]

Ready for review.

[codecov-io]

Codecov Report

Merging #1377 into master will decrease coverage by -0.01%.
The diff coverage is 54.16%.

@@             Coverage Diff              @@
##             master    #1377      +/-   ##
============================================
- Coverage     54.29%   54.29%   -0.01%     
- Complexity    20926    20930       +4     
============================================
  Files          1297     1298       +1     
  Lines         79830    79854      +24     
  Branches       1254     1254              
============================================
+ Hits          43343    43356      +13     
- Misses        36487    36498      +11

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Repair.php	30.98% <0%> (-0.45%)	19 <0> (ø)
lib/private/Repair/NC12/UpdateLanguageCodes.php	56.52% <56.52%> (ø)	4 <4> (?)
lib/private/Server.php	92.61% <0%> (-0.17%)	120% <0%> (ø)
lib/private/Security/CertificateManager.php	93.81% <0%> (+1.03%)	38% <0%> (ø)	❌

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4067a...1bcd396. Read the comment docs.

[nickvergessen]

Extended the tests for a case with more than 1 user and fixed the table name in the output

[rullzer]

Looks good to me 👍

[MorrisJobke]

I need to look into fixing the backports of the wrong translations or we simply backport this one here. 2282e61

Maybe I just copy over the now renamed stuff to the old version for all the changed languages in the translation script.