Skip to content

Conversation

@jeffkala
Copy link
Collaborator

No description provided.

qduk and others added 13 commits January 11, 2022 12:53
Dynamically gather start and end lines for doc testing
* Added uptime conversion functions
Co-authored-by: Justin Drew <jdrew82@users.noreply.github.com>
* fix: 🐛 Handle 0 decimal place rounding for bits_to_name

There appears to be a quirk with the round method that it will show the number as a float if you specify 0 decimal places and as an int if you don't specify the places at all. This tweak should fix the issue.
* Removed double for loop and use builtin regex to find all matches across lines.

* Change multiline test to include minimal vlan range of concurrent (2), ex. 1912-1913

* Corrected checking max vlan back to original checking the last element.
* Add grouping_size to vlanlist_to_config.

* Add tests for and logic to assert group size is not less than 2.

* Allow grouping size of 1, but it returns the vlan list, sorted, and joined with no special processing.

* Update netutils/vlan.py

Co-authored-by: Ken Celenza <ken@celenza.org>

* Update netutils/vlan.py

Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>

Co-authored-by: Ken Celenza <ken@celenza.org>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
* test: ✅ Add SrOS config samples for parser

* feat: ✨ Add SrOS parser utilizing section banners as config section parents

In order to allow the config section banners to be used for specifying a section in parsing I've simplified it so those banner names are the parent for the section. Should allow for a user to specify "System Configuration" for a section and get the full block.

* refactor: 🔥 Remove config_lines_only method

Realized I could use the inherited method just as well as the one I'd written so getting rid of unnecessary code.

* refactor: 🔥 Remove unused method

* docs: Remove reference to Fortinet

* refactor: 🚚 Rename methods to be private per convention

* fix: Simply comment character to just hash symbol

* test: ✅ Add SROS base config sample for parser test

* test: ✅ Add SROS compliance tests

* test: ✅ Add diff_network_config test for SROS parser

* test: ✅ Add SROS config test for config not parsed

* test: ✅ Fix config_section_not_parsed test for SROS

Updated test to use post-processed config for the test

* build: Increment project minor version to 1.1.0

* docs: 📝 Add note about SROS edge case config modification

Co-authored-by: Justin Drew <jdrew82@users.noreply.github.com>
@jeffkala jeffkala merged commit 081d226 into main Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants