Fix decimal place in bits_to_name #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be a quirk with the round method that it will show the number as a float if you specify 0 decimal places and as an int if you don't specify the places at all. This tweak should fix the issue.
jdrew82
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
jeffkala
approved these changes
Feb 14, 2022
netutils/bandwidth.py
Outdated
| if val["low"] <= speed < val["high"]: | ||
| try: | ||
| return f"{round(speed / val['low'], nbr_decimal)}{bit_type}" | ||
| if nbr_decimal != 0: |
Contributor
There was a problem hiding this comment.
To keep it a bit more dry, does this make sense?
if nbr_decimal == 0
nbr_decimal = None
>>> round(1500 / 100, None)
15
>>> round(1500 / 100, 0)
15.0
>>>
Contributor
Author
There was a problem hiding this comment.
Good call. I've refactored this bit to remove duplication and simplify it.
| {"sent": {"speed": 1000000000, "nbr_decimal": 1}, "received": "1.0Gbps"}, | ||
| {"sent": {"speed": 1000000000000}, "received": "1.0Tbps"}, | ||
| {"sent": {"speed": 1000000000000}, "received": "1Tbps"}, | ||
| {"sent": {"speed": 1000000000000, "nbr_decimal": 1}, "received": "1.0Tbps"}, |
Contributor
There was a problem hiding this comment.
Can we add one example of a non-zero?
There appears to be a quirk with the round method that it will show the number as a float if you specify 0 decimal places and as an int if you don't specify the places at all. This tweak should fix the issue. refactor: ♻️ Simplify code to reduce code duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #85. There appears to be a quirk with the round method that it will show the number as a float if you specify 0 decimal places and as an int, if you don't specify the places at all. This tweak should address the quirk and represent the name as expected.