Skip to content

PixelationPassNode: Simplify Code. - #34543

Merged
Mugen87 merged 5 commits into
mrdoob:devfrom
cmhhelgeson:cmh/simplify_pixel
Sep 12, 2026
Merged

PixelationPassNode: Simplify Code.#34543
Mugen87 merged 5 commits into
mrdoob:devfrom
cmhhelgeson:cmh/simplify_pixel

Conversation

@cmhhelgeson

Copy link
Copy Markdown
Contributor

Description

Simplifies the PixelationPassNode code by properly using getTextureNode and textureSize. Additionally adds some comments to specify how the effect might differ from RetroPassNode.

@Mugen87

Mugen87 commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

I've extended the refactoring with a few additions and corrections:

  • The pixelSize is now a number only. It does not make sense to allow a TSL object since the value is never used in the shader.
  • Use toConst()/toVar() where appropriate.
  • Minor JSDoc and typo corrections.

The pixelSize change is a breaking one, I'll note that in the migration guide.

@Mugen87 Mugen87 added this to the r187 milestone Sep 12, 2026
@Mugen87 Mugen87 changed the title PixelationPassNode - Simplify Code PixelationPassNode: Simplify Code. Sep 12, 2026
@Mugen87
Mugen87 merged commit 3996573 into mrdoob:dev Sep 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants