Repository navigation
move TrajectoryExecutionManager::clear() to private (backport #3226) - #3237
Merged
Merged
Conversation
* move TrajectoryExecutionManager::clear() to private Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> --------- Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> (cherry picked from commit 3ec75ab) # Conflicts: # moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp # moveit_ros/move_group/src/default_capabilities/execute_trajectory_action_capability.cpp # moveit_ros/planning/plan_execution/src/plan_execution.cpp # moveit_ros/planning/trajectory_execution_manager/include/moveit/trajectory_execution_manager/trajectory_execution_manager.hpp
Author
|
Cherry-pick of 3ec75ab has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## humble #3237 +/- ##
=======================================
Coverage 51.41% 51.41%
=======================================
Files 382 382
Lines 31893 31893
=======================================
Hits 16396 16396
Misses 15497 15497 ☔ View full report in Codecov by Sentry. |
Contributor
|
Yes, I think so. I backported it to MoveIt1 as well. |
sea-bass
approved these changes
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
previously discussed here #3198 (comment)
Checklist
This is an automatic backport of pull request #3226 done by [Mergify](https://mergify.com).