Repository navigation
move TrajectoryExecutionManager::clear() to private - #3226
Merged
Merged
Conversation
Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3226 +/- ##
==========================================
- Coverage 45.67% 45.64% -0.02%
==========================================
Files 714 714
Lines 62299 62293 -6
Branches 7531 7529 -2
==========================================
- Hits 28446 28425 -21
- Misses 33687 33701 +14
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
6 tasks
rhaschke
reviewed
Jan 11, 2025
sea-bass
added
backport-humble
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
Contributor
Author
|
Updated with suggestions applied, thanks! |
rhaschke
approved these changes
Jan 12, 2025
sea-bass
added this pull request to the merge queue
Jan 12, 2025
mergify Bot
pushed a commit
that referenced
this pull request
Jan 12, 2025
* move TrajectoryExecutionManager::clear() to private Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> --------- Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> (cherry picked from commit 3ec75ab) # Conflicts: # moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp # moveit_ros/move_group/src/default_capabilities/execute_trajectory_action_capability.cpp # moveit_ros/planning/plan_execution/src/plan_execution.cpp # moveit_ros/planning/trajectory_execution_manager/include/moveit/trajectory_execution_manager/trajectory_execution_manager.hpp
6 tasks
mergify Bot
pushed a commit
that referenced
this pull request
Jan 12, 2025
* move TrajectoryExecutionManager::clear() to private Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> --------- Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> (cherry picked from commit 3ec75ab)
6 tasks
sea-bass
pushed a commit
that referenced
this pull request
Jan 12, 2025
Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> (cherry picked from commit 3ec75ab) Co-authored-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com>
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
Jan 12, 2025
sea-bass
pushed a commit
that referenced
this pull request
Jan 12, 2025
sussybot5258
pushed a commit
to GreyCatAI/moveit2
that referenced
this pull request
Apr 19, 2025
* move TrajectoryExecutionManager::clear() to private Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> --------- Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
Markus-Simonsen
pushed a commit
to Markus-Simonsen/moveit2
that referenced
this pull request
Aug 12, 2025
* move TrajectoryExecutionManager::clear() to private Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> --------- Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
rhaschke
added a commit
to moveit/moveit
that referenced
this pull request
Aug 24, 2025
* Fix race condition when stopping trajectory execution backport of moveit/moveit2#3198 * Move TrajectoryExecutionManager::clear() to private backport of moveit/moveit2#3226
helen9975
pushed a commit
to personalrobotics/moveit2
that referenced
this pull request
Feb 17, 2026
* move TrajectoryExecutionManager::clear() to private Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> --------- Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
previously discussed here #3198 (comment)
Checklist