ORT Update: Create MLGraphBuilder for every model builder - #21
Merged
Merged
Conversation
Dwayne Robinson (fdwr)
approved these changes
Jul 26, 2024
Dwayne Robinson (fdwr)
left a comment
Dwayne Robinson (fdwr)
left a comment
Collaborator
There was a problem hiding this comment.
👍 TY. Will wait for other ORT CR to complete to ensure no other changes to it.
Collaborator
|
Merged microsoft/onnxruntime#21514. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #20 Error: "This MLGraphBuilder has already built a graph"
This PR updated the internal ONNX Runtime Web dists built with change of onnxruntime/pull/21514 Create MLGraphBuilder for every model builder by Wanming Lin (@Honry) . There is no error for SA and other dev preview demos on Canary 129.0.6617.0 .
Reference: webmachinelearning/webnn#717 Allow MLGraphBuilder.build() to be called only once
Dwayne Robinson (@fdwr) Adele101 Please only merge this PR if no further changes in microsoft/onnxruntime#21514 , or we need to continute to update the ORT dists based on your review feedback.