Skip to content

[WebNN EP] Create MLGraphBuilder for every model builder - #21514

Merged
Dwayne Robinson (fdwr) merged 2 commits into
microsoft:mainfrom
Honry:dont-reuse-builder
Aug 1, 2024
Merged

[WebNN EP] Create MLGraphBuilder for every model builder#21514
Dwayne Robinson (fdwr) merged 2 commits into
microsoft:mainfrom
Honry:dont-reuse-builder

Conversation

@Honry

@Honry Wanming Lin (Honry) commented Jul 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Currently WebNN spec only allows MLGraphBuilder.build() to be called once, we need to create new builder for every subgraph in WebNN EP.

Spec change: webmachinelearning/webnn#717

@Honry

Wanming Lin (Honry) commented Jul 26, 2024

Copy link
Copy Markdown
Contributor Author

Dwayne Robinson (@fdwr), Guenther Schmuelling (@guschmue), Ningxin Hu (@huningxin), PTAL, thanks!

@Honry Wanming Lin (Honry) mentioned this pull request Jul 26, 2024
Closed
huningxin
Ningxin Hu (huningxin) approved these changes Jul 26, 2024
View reviewed changes

@huningxin Ningxin Hu (huningxin) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment.

BTW, you may want to refer to the spec change PR: webmachinelearning/webnn#717

Comment thread onnxruntime/core/providers/webnn/builders/model_builder.h Outdated
@ibelem Belem Zhang (ibelem) mentioned this pull request Jul 26, 2024
Merged
huningxin
Ningxin Hu (huningxin) approved these changes Jul 26, 2024
View reviewed changes

@huningxin Ningxin Hu (huningxin) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fdwr
Dwayne Robinson (fdwr) approved these changes Jul 26, 2024
View reviewed changes

@fdwr Dwayne Robinson (fdwr) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr Dwayne Robinson (fdwr) added the ep:WebNN WebNN execution provider label Jul 26, 2024
@fdwr

Dwayne Robinson (fdwr) commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr

Dwayne Robinson (fdwr) commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr

Dwayne Robinson (fdwr) commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines

azure-pipelines Bot commented Jul 26, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines

azure-pipelines Bot commented Jul 26, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines

azure-pipelines Bot commented Jul 26, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 9 pipeline(s).

@fdwr

Dwayne Robinson (fdwr) commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

/azp run Windows GPU TensorRT CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Jul 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@fdwr

Dwayne Robinson (fdwr) commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr

Dwayne Robinson (fdwr) commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr

Dwayne Robinson (fdwr) commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines

azure-pipelines Bot commented Jul 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines

azure-pipelines Bot commented Jul 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines

azure-pipelines Bot commented Jul 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 9 pipeline(s).

@fdwr

Dwayne Robinson (fdwr) commented Jul 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Wanming Lin (@Honry) Merge with your most recent change for the Web CI failures?

@Honry
[WebNN EP] Create MLGraphBuilder for every model builder
74c63bb 
Currently WebNN spec only allows MLGraphBuilder.build() to be called
once, we need to create builder for every subgraph in WebNN EP.
@Honry
Release WebNN builder after graph built
57dbebb
@Honry

Wanming Lin (Honry) commented Aug 1, 2024

Copy link
Copy Markdown
Contributor Author

Wanming Lin (@Honry) Merge with your most recent change for the Web CI failures?

Sure, done, pls. help retrigger the CI. Thanks!

@fdwr

Dwayne Robinson (fdwr) commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr

Dwayne Robinson (fdwr) commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr

Dwayne Robinson (fdwr) commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines

azure-pipelines Bot commented Aug 1, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines

azure-pipelines Bot commented Aug 1, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines

azure-pipelines Bot commented Aug 1, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 9 pipeline(s).

@fdwr
Dwayne Robinson (fdwr) merged commit 8c2ee7b into microsoft:main Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdwr Dwayne Robinson (fdwr) fdwr approved these changes
+1 more reviewer
@huningxin Ningxin Hu (huningxin) huningxin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ep:WebNN WebNN execution provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Honry @fdwr @huningxin