Remove two stale IDE0060 suppressions - #16373
Merged
Jakub Jareš (nohwnd) merged 2 commits intoAug 18, 2026
Merged
Jakub Jareš (nohwnd) merged 2 commits into
Jakub Jareš (nohwnd) merged 2 commits into
Conversation
Delete the unused VersionAttribute and remove obsolete parameters from the attach-debugger conversion. Cover payload propagation and negotiated callback serialization. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> 🤖
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements “Task 3” from issue #16367 by removing two stale IDE0060 suppressions and the underlying unused API surface in the VSTest communication layer, while adding unit coverage for the AttachDebugger wire message path with negotiated protocol versions.
Changes:
- Removed the unused
VersionAttribute(and its TODO-backed IDE0060 suppression) from PlatformAbstractions. - Simplified
MessageConverter.ConvertToAttachDebuggerInfoby removing unused parameters and updating the AttachDebugger handling call site. - Added a unit test validating AttachDebugger conversion + callback serialization using the negotiated protocol version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/Microsoft.TestPlatform.CommunicationUtilities.UnitTests/TestRequestSenderTests.cs |
Adds AttachDebugger coverage for negotiated protocol version and payload-to-AttachDebuggerInfo mapping. |
src/Microsoft.TestPlatform.PlatformAbstractions/VersionAttribute.cs |
Deletes an unused DEBUG-only attribute that only existed with an IDE0060 suppression/TODO. |
src/Microsoft.TestPlatform.CommunicationUtilities/TestRequestSender.cs |
Removes unused parameters from AttachDebugger conversion and updates the message handler accordingly. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jakub Jareš (nohwnd)
marked this pull request as ready for review
August 17, 2026 16:56
Jakub Jareš (nohwnd)
marked this pull request as draft
August 17, 2026 16:56
Jakub Jareš (nohwnd)
marked this pull request as ready for review
August 18, 2026 09:15
Jakub Jareš (nohwnd)
enabled auto-merge (squash)
August 18, 2026 13:55
Petr Pokorny (0101)
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented and committed Task 3 from microsoft/vstest#16367.
Deleted unused VersionAttribute, removed obsolete ConvertToAttachDebuggerInfo parameters and both TODO-backed IDE0060 suppressions, and added coverage for debugger fields, callback type, wire format, and negotiated version.
Evidence:
🤖