Skip to content

Adopt problems panel to use views and view container - #87245

Merged
Sandeep Somavarapu (sandy081) merged 6 commits into
masterfrom
sandy081/moveProblemsToView
Dec 18, 2019
Merged

Adopt problems panel to use views and view container#87245
Sandeep Somavarapu (sandy081) merged 6 commits into
masterfrom
sandy081/moveProblemsToView

Conversation

@sandy081

@sandy081 Sandeep Somavarapu (sandy081) commented Dec 18, 2019

Copy link
Copy Markdown
Member

This PR fixes #87243

Adoptions:

  • update to body -> layoutBody, renderBody,
  • do not have public render method
  • Memento State
  • Rendering title actions and body are in reverse order
  • Fix when title bar actions are rendered twice

Existing

  • Dispose is not called on hiding panel
  • Cmd+J toggle is not focusing problems

@sandy081
Sandeep Somavarapu (sandy081) deleted the sandy081/moveProblemsToView branch December 18, 2019 11:21
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@sandy081 Sandeep Somavarapu (sandy081)

Labels

None yet

Projects

None yet

Milestone

January 2020

Development

Successfully merging this pull request may close these issues.

Adopt problems panel to use views and view containers

1 participant

@sandy081