Skip to content

Adopt problems panel to use views and view containers #87243

Closed

Description

Adopt problems panel to use views and view containers

Re: #85164

Adoptions & Notes:

  • Use renderBody instead of create and layoutBody instead of layout
  • If you have public render method rename it to something else like renderContent
  • Create your own memento State - important
  • Header is rendered first and then body. But before body is rendered first and then actions (header). So please be aware of this so that you can fix if there are dependencies
  • Header actions are rendered twice now because of merging single view to header. This needs to be fixed.

Existing Before and Shall be considered now:

  • Dispose is not called on hiding panel
  • Cmd+J toggle is not focusing problems

Activity

  1. added a commit that references this issue on Dec 18, 2019
  2. sandy081 commented on Dec 18, 2019

    @sandy081
    MemberAuthor

    Introduced donotShowContainerTitleWhenMergedWithContainer option to hide title when in single view which is needed for problems adoption.

    donotShowContainerTitleWhenMergedWithContainer?: boolean;

  3. sandy081 commented on Dec 18, 2019

    @sandy081
    MemberAuthor

    Pushed adoption changes to master and problems panel now uses views and view containers 🎉

    Listed in summary what are the adoptions required.

  4. sandy081 commented on Dec 18, 2019

    @sandy081
    MemberAuthor
  5. locked and limited conversation to collaborators on Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

debtCode quality issues

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions