Skip to content

[cherry-pick] fix: bump shared memory to support software compositor allocation pressure - #319514

Merged
Robo (deepak1556) merged 1 commit into
release/1.123from
cherry-pick/319508
Jun 2, 2026
Merged

[cherry-pick] fix: bump shared memory to support software compositor allocation pressure#319514
Robo (deepak1556) merged 1 commit into
release/1.123from
cherry-pick/319508

Conversation

@vs-code-engineering

@vs-code-engineering vs-code-engineering Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Cherry-pick of #319508 from main.

The Fedora and Debian desktop sanity tests crash shortly after launch (SIGTRAP) when run inside the Docker containers. The aborts originate from two software-compositor allocation paths, both backed by shared memory on Linux:

  (cc::TileManager -> ZeroCopyRasterBufferImpl ->
   CreateSharedImageForSoftwareCompositor)
- base::DiscardableMemoryAllocator::
  AllocateLockedDiscardableMemoryWithRetryOrDie
  (SkMipmap::Build -> SoftwareImageDecodeCache)

Docker gives a container a default /dev/shm of only 64 MB. Once shared memory fills, the SharedImage and discardable allocations fail crashing the process.

Fixes #318542
Fixes https://github.com/microsoft/vscode-engineering/issues/2877

Copilot AI review requested due to automatic review settings June 2, 2026 04:37
@vs-code-engineering vs-code-engineering Bot added the cherry-pick-artifact Auto-generated cherry-pick PR label Jun 2, 2026
Copilot AI reviewed Jun 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vs-code-engineering

vs-code-engineering Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Dmitriy Vasyura (@dmitrivMS)

Matched files:

  • test/sanity/scripts/run-docker.sh

@deepak1556
Robo (deepak1556) enabled auto-merge (squash) June 2, 2026 04:51
@deepak1556
Robo (deepak1556) merged commit b3dde03 into release/1.123 Jun 2, 2026
25 checks passed
@deepak1556
Robo (deepak1556) deleted the cherry-pick/319508 branch June 2, 2026 05:08
@vs-code-engineering vs-code-engineering Bot added this to the 1.123.0 milestone Jun 2, 2026
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Jul 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@deepak1556 Robo (deepak1556) deepak1556 approved these changes
@dmitrivMS Dmitriy Vasyura (dmitrivMS) dmitrivMS approved these changes

Assignees

@deepak1556 Robo (deepak1556)

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Milestone

1.123.0

Development

Successfully merging this pull request may close these issues.

3 participants

@deepak1556 @dmitrivMS