Skip to content

fix: bump shared memory to support software compositor allocation pressure - #319508

Merged
Robo (deepak1556) merged 1 commit into
mainfrom
robo/fix_sanity_runner_crash
Jun 2, 2026
Merged

Robo (deepak1556) merged 1 commit into
mainfrom
robo/fix_sanity_runner_crash

Conversation

@deepak1556

Copy link
Copy Markdown
Collaborator

The Fedora and Debian desktop sanity tests crash shortly after launch (SIGTRAP) when run inside the Docker containers. The aborts originate from two software-compositor allocation paths, both backed by shared memory on Linux:

  (cc::TileManager -> ZeroCopyRasterBufferImpl ->
   CreateSharedImageForSoftwareCompositor)
- base::DiscardableMemoryAllocator::
  AllocateLockedDiscardableMemoryWithRetryOrDie
  (SkMipmap::Build -> SoftwareImageDecodeCache)

Docker gives a container a default /dev/shm of only 64 MB. Once shared memory fills, the SharedImage and discardable allocations fail crashing the process.

Fixes #318542
Fixes https://github.com/microsoft/vscode-engineering/issues/2877

@deepak1556 Robo (deepak1556) added this to the 1.124.0 milestone Jun 2, 2026
@deepak1556 Robo (deepak1556) self-assigned this Jun 2, 2026
Copilot AI review requested due to automatic review settings June 2, 2026 03:56
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Dmitriy Vasyura (@dmitrivMS)

Matched files:

  • test/sanity/scripts/run-docker.sh

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Increases Docker container shared memory for Linux desktop sanity tests to prevent crashes caused by /dev/shm exhaustion in default Docker configurations (notably in CI containers).

Changes:

  • Add --shm-size=2g to the sanity-test docker run invocation to avoid shared-memory-backed allocation failures.

@deepak1556
Robo (deepak1556) enabled auto-merge (squash) June 2, 2026 04:12
@deepak1556
Robo (deepak1556) merged commit 9948917 into main Jun 2, 2026
58 checks passed
@deepak1556
Robo (deepak1556) deleted the robo/fix_sanity_runner_crash branch June 2, 2026 04:34
@dmitrivMS

Copy link
Copy Markdown
Collaborator

Robo (@deepak1556) Thanks for getting to the bottom of it!

@dmitrivMS Dmitriy Vasyura (dmitrivMS) added the ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch label Jun 2, 2026
@dmitrivMS

Copy link
Copy Markdown
Collaborator

We may want it in the release branch as sanity tests may be failing there as well.

@vs-code-engineering vs-code-engineering Bot added release-cherry-pick Automated cherry-pick between release and main branches and removed ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch labels Jun 2, 2026
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Jul 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-cherry-pick Automated cherry-pick between release and main branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fedora 43 x64 desktop sanity test crashes with Electron 42

3 participants