Skip to content

chore: show deprecation banner for arm32 remote connections #317063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Robo (deepak1556) merged 1 commit into from
May 18, 2026
Merged

chore: show deprecation banner for arm32 remote connections #317063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 45 additions & 18 deletions src/vs/workbench/contrib/remote/browser/remoteConnectionHealth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { IWorkbenchContribution } from '../../../common/contributions.js';
import { IRemoteAgentService, remoteConnectionLatencyMeasurer } from '../../../services/remote/common/remoteAgentService.js';
import { IWorkbenchEnvironmentService } from '../../../services/environment/common/environmentService.js';
import { localize } from '../../../../nls.js';
import { isWeb } from '../../../../base/common/platform.js';
import { isWeb, OperatingSystem } from '../../../../base/common/platform.js';
import { ITelemetryService } from '../../../../platform/telemetry/common/telemetry.js';
import { getRemoteName, getRemoteServerRootPath } from '../../../../platform/remote/common/remoteHosts.js';
import { IBannerService } from '../../../services/banner/browser/bannerService.js';
Expand All @@ -18,10 +18,12 @@ import { IProductService } from '../../../../platform/product/common/productServ
import { IDialogService } from '../../../../platform/dialogs/common/dialogs.js';
import { Codicon } from '../../../../base/common/codicons.js';
import Severity from '../../../../base/common/severity.js';
import { ILinkDescriptor } from '../../../../platform/opener/browser/link.js';


const REMOTE_UNSUPPORTED_CONNECTION_CHOICE_KEY = 'remote.unsupportedConnectionChoice';
const BANNER_REMOTE_UNSUPPORTED_CONNECTION_DISMISSED_KEY = 'workbench.banner.remote.unsupportedConnection.dismissed';
const BANNER_REMOTE_ARM32_DEPRECATION_DISMISSED_KEY = 'workbench.banner.remote.arm32Deprecation.dismissed';

export class InitialRemoteConnectionHealthContribution implements IWorkbenchContribution {

Expand Down Expand Up @@ -84,40 +86,45 @@ export class InitialRemoteConnectionHealthContribution implements IWorkbenchCont
private async _checkInitialRemoteConnectionHealth(): Promise<void> {
try {
const environment = await this._remoteAgentService.getRawEnvironment();
const isArm32Server = environment?.os === OperatingSystem.Linux && environment.arch === 'arm';

if (environment && environment.isUnsupportedGlibc) {
let allowed = this.storageService.getBoolean(`${REMOTE_UNSUPPORTED_CONNECTION_CHOICE_KEY}.${this._environmentService.remoteAuthority}`, StorageScope.PROFILE);
if (allowed === undefined) {
allowed = await this._confirmConnection();
}
if (allowed) {
const bannerDismissedVersion = this.storageService.get(`${BANNER_REMOTE_UNSUPPORTED_CONNECTION_DISMISSED_KEY}`, StorageScope.PROFILE) ?? '';
// Ignore patch versions and dismiss the banner if the major and minor versions match.
const shouldShowBanner = bannerDismissedVersion.slice(0, bannerDismissedVersion.lastIndexOf('.')) !== this.productService.version.slice(0, this.productService.version.lastIndexOf('.'));
if (shouldShowBanner) {
const actions = [
this._showVersionedBanner(
'unsupportedGlibcWarning.banner',
BANNER_REMOTE_UNSUPPORTED_CONNECTION_DISMISSED_KEY,
localize('unsupportedGlibcWarning.banner', "You are connected to an OS version that is unsupported by {0}.", this.productService.nameLong),
[
{
label: localize('unsupportedGlibcBannerLearnMore', "Learn More"),
href: 'https://aka.ms/vscode-remote/faq/old-linux'
}
];
this.bannerService.show({
id: 'unsupportedGlibcWarning.banner',
message: localize('unsupportedGlibcWarning.banner', "You are connected to an OS version that is unsupported by {0}.", this.productService.nameLong),
actions,
icon: Codicon.warning,
closeLabel: `Do not show again in v${this.productService.version}`,
onClose: () => {
this.storageService.store(`${BANNER_REMOTE_UNSUPPORTED_CONNECTION_DISMISSED_KEY}`, this.productService.version, StorageScope.PROFILE, StorageTarget.MACHINE);
}
});
}
]
);
} else {
this.hostService.openWindow({ forceReuseWindow: true, remoteAuthority: null });
return;
}
}

if (isArm32Server) {
this._showVersionedBanner(
'arm32ServerDeprecation.banner',
BANNER_REMOTE_ARM32_DEPRECATION_DISMISSED_KEY,
localize('arm32ServerDeprecation.banner', "Support for 32-bit ARM remote servers is deprecated and will be removed in a future release of {0}.", this.productService.nameLong),
[
{
label: localize('arm32ServerDeprecationBannerLearnMore', "Learn More"),
href: 'https://aka.ms/vscode-remote-linux-arm-32-eol'
}
]
);
}

type RemoteConnectionSuccessClassification = {
owner: 'alexdima';
comment: 'The initial connection succeeded';
Expand Down Expand Up @@ -167,6 +174,26 @@ export class InitialRemoteConnectionHealthContribution implements IWorkbenchCont
}
}

private _showVersionedBanner(id: string, storageKey: string, message: string, actions?: ReadonlyArray<ILinkDescriptor>): void {
const bannerDismissedVersion = this.storageService.get(storageKey, StorageScope.PROFILE) ?? '';
// Ignore patch versions and dismiss the banner if the major and minor versions match.
const shouldShowBanner = bannerDismissedVersion.slice(0, bannerDismissedVersion.lastIndexOf('.')) !== this.productService.version.slice(0, this.productService.version.lastIndexOf('.'));
if (!shouldShowBanner) {
return;
}

this.bannerService.show({
id,
message,
actions,
icon: Codicon.warning,
closeLabel: localize('remoteBannerDoNotShowAgainThisVersion', "Do not show again in v{0}", this.productService.version),
onClose: () => {
this.storageService.store(storageKey, this.productService.version, StorageScope.PROFILE, StorageTarget.MACHINE);
}
});
}

private async _measureExtHostLatency() {
const measurement = await remoteConnectionLatencyMeasurer.measure(this._remoteAgentService);
if (measurement === undefined) {
Expand Down
Loading