Repository navigation
chore: show deprecation banner for arm32 remote connections - #317063
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a version-scoped warning banner when connecting to 32-bit ARM (Linux arm) remote servers, in preparation for upcoming platform changes (Electron v42 work). Also refactors the existing “unsupported glibc” warning banner logic into a shared helper to ensure consistent “dismiss for this version” behavior.
Changes:
- Detect Linux arm32 remote servers (
environment.arch === 'arm') and show a deprecation warning banner. - Factor banner display + “dismiss until next minor/major version” logic into
_showVersionedBanner. - Reuse the helper for the existing unsupported-glibc warning banner.
Contributor
|
Base:
|
This was referenced May 18, 2026
Robo (deepak1556)
force-pushed
the
robo/deprecate_arm_server
branch
from
May 18, 2026 18:02
7e9022b to
7ce7c58
Compare
Collaborator
Author
|
Robo (deepak1556)
marked this pull request as ready for review
May 18, 2026 23:05
Robo (deepak1556)
enabled auto-merge (squash)
May 18, 2026 23:05
Ben Villalobos (benvillalobos)
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for #316661