[Mike Griese (zadjii-msft)]

Summary of the Pull Request

Adds support for setting a command's icon. This supports a couple different scenarios:

• setting a path to an image
• on "iterateOn": "profiles" commands, setting the icon to ${profile.icon} (to use the profile's icon)
• setting the icon to a symbol from Segoe MDL2 Assets
• setting the icon to an emoji
• setting the icon to a character (what is an emoji other than a character, after all?)

References

• Big s/o to Leon Liang (@leonMSFT) in Advanced Tab Switcher #6732, who really did all the hard work here.

PR Checklist

• Closes Command palette entries should have optional icons #6644
• I work here
• Tests added/passed
• [n/a] Requires documentation to be updated

Detailed Description of the Pull Request / Additional comments

Importantly, the creation of these icons must occur on the UI thread. That's why it's done in a "load the path from json", then "get the actual IconSource" structure.

Validation Steps Performed

see the gif

[Mike Griese (zadjii-msft)]

Some hopefully useful symbols:

icon	codepoint	name
	F57C	CollatePortrait
	F614	DoublePortrait
	F615	DoubleLandscape
	E8A0	OpenPane
	E784	GripperBarVertical
	E76F	GripperBarHorizontal
	E756	CommandPrompt
	E713	Setting
	F7ED	WindowSnipping

Man there are just not very many good pane icons for us to use. There's an icon for the number 16 but no good panes ones :/

[Dustin L. Howett (DHowett)]

SHIP IT

[Leon Liang (leonMSFT)]

oh man I love that you're able to use anything as an icon and it'll just know what to do

F57C and its 90deg rotato version could be good for split panes?

[Mike Griese (zadjii-msft)]

Man I thought emoji would come to the rescue, but not so much. Fuse is close to a hypothetical "WHITE SQUARE WITH CENTRE HORIZONTAL LINE", but that doesn't exist. Neither does "WHITE SQUARE WITH HORIZONTAL BISECTING LINE"

Character	Name	Browser	Image
U+25E7	SQUARE WITH LEFT HALF BLACK	◧	view
U+25E8	SQUARE WITH RIGHT HALF BLACK	◨	view
U+2385	WHITE SQUARE WITH CENTRE VERTICAL LINE	⎅	view
U+23DB	FUSE	⏛	view
U+25EB	WHITE SQUARE WITH VERTICAL BISECTING LINE	◫	view
U+2B12	SQUARE WITH TOP HALF BLACK	⬒	view
U+2B13	SQUARE WITH BOTTOM HALF BLACK	⬓	view

[Mike Griese (zadjii-msft)]

F57C and its 90deg rotato version could be good for split panes?

Yea, now I've gotta introduce a rotation variable too, but that's not too horrifying.

[Deleted user (ghost)]

Hello Mike Griese (@zadjii-msft)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 17 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[Mike Griese (zadjii-msft)]

@msftbot merge this in like 1 minute

[Deleted user (ghost)]

Hello Mike Griese (@zadjii-msft)!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I won't merge this pull request until after the UTC date Fri, 21 Aug 2020 18:07:08 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

[Deleted user (ghost)]

🎉Windows Terminal Preview v1.3.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download