Advanced Tab Switcher by leonMSFT · Pull Request #6732 · microsoft/terminal

Leon Liang (leonMSFT) · 2020-06-30T17:22:43Z

Summary of the Pull Request

This PR adds the Advanced Tab Switcher (ATS) to Terminal. It'll work
similarly to VSCode's tab switcher. Because this implementation rides
off a lot of the Command Palette's XAML code, it'll look just like the
Command Palette, and also have support for tab title search.

References

#3753 - ATS Spec

Closes #1502

Carlos Zamora (carlos-zamora)

UX Issues

Downloaded the branch and got to play around with it for a bit. Found a few big UX issues. After they get fixed/resolved, I'll do another sweep and test out accessibility.

Command Palette Inaccessible

After opening the Tab Switcher, I can now only open the Tab Switcher. When I press the Command Palette keybinding, the Tab Switcher opens instead.

Going Backwards on the Tab Switcher

I bound tabSwitcher to ctrl+tab. Pressing tab gets me the next item in the list. But I'd expect pressing ctrl+shift+tab to go to the previous item.

"Search" box

When we're in anchor mode, it feels a bit weird to have a text box appear, but we can't type into it. I'd bet screen readers would make this extra confusing too because it would read the text box, that you can't type into.

Tab Switcher Results Order

I can't figure out the of the results (I think I got into a bad state somehow). I'd expect them to be in order by index though.

Rearranging Tabs

I created a new tab, then dragged it to index 2 (from 4). I somehow ended up with this:

komawoyo · 2020-07-05T18:04:41Z

Just an idea. Would it be favorable to also include the icons next to the names in the drop down? Maybe a before and after to compare.

…tab icons

Leon Liang (leonMSFT) · 2020-07-09T18:48:11Z

Maybe there needs to be a bit more spacing between the "Icon" column and the "Name" column?

Mike Griese (zadjii-msft) · 2020-07-09T19:17:47Z

Design feedback: (full review in progress)

I fricken love that you got the icons figured out. Now we can follow up by letting commands specify the icon too! (not in this PR for sure)

I agree that they maybe need a tad bit more spacing.

I'm not sure I love the labels for Index:0 etc.

Maybe change the Type a command name... string depending on which mode we're in?

Mike Griese (zadjii-msft)

I'm really happy with how smooth this seems. I've got nits throughout, so I'm blocking just so GH won't lose my progress, but I'm really looking forward to this.

Mike Griese (zadjii-msft) · 2020-08-10T21:35:55Z

Deleted user (ghost) · 2020-08-11T14:02:42Z

Hello Mike Griese (@zadjii-msft)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

@leonMSFT

## Summary of the Pull Request ![cmdpal-icons](https://user-images.githubusercontent.com/18356694/90916410-97dada00-e3a6-11ea-9fb0-755938a68a05.gif) Adds support for setting a command's `icon`. This supports a couple different scenarios: * setting a path to an image * on `"iterateOn": "profiles"` commands, setting the icon to `${profile.icon}` (to use the profile's icon) * setting the icon to a symbol from [Segoe MDL2 Assets](https://docs.microsoft.com/en-us/windows/uwp/design/style/segoe-ui-symbol-font) * setting the icon to an emoji * setting the icon to a character (what is an emoji other than a character, after all?) ## References * Big s/o to @leonMSFT in #6732, who really did all the hard work here. ## PR Checklist * [x] Closes #6644 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments Importantly, the creation of these icons must occur on the UI thread. That's why it's done in a "load the path from json", then "get the actual IconSource" structure. ## Validation Steps Performed see the gif

Deleted user (ghost) · 2020-08-26T17:05:03Z

🎉Windows Terminal Preview v1.3.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

Russell R. Riker (Dr-WaSaBi) · 2020-09-01T20:21:29Z

Love all the new stuff in 1.3. Great job

Russ

Simon Ratner (simonratner) · 2020-09-04T07:26:08Z

We'd love feedback on why the new tab switcher didn't work for you!

Not sure where this feedback should go, this seems like a reasonable place. I found it distracting to pop up on ctrl+tab every time, so I turned it off.

I do find the list of tabs to be valuable, but would prefer it to be accessible with a separate key (I guess that's the tabSearch action, which I have bound to ctrl+`).

Pete DeBiase (pete-debiase) · 2020-09-20T03:42:06Z

Strongly agree with Simon Ratner (@simonratner) on the Advanced Tab Switcher - when I press ctrl+tab or ctrl+shift+tab, I just want to go to the next/previous tab, not get a modal popup. The tabSearch action does seem to be a better application of this functionality in terms of having a way to efficiently navigate through large numbers of open tabs.

Having said that, I thought the implementation of Advanced Tab Switcher was very clean. And since you exposed the useTabSwitcher setting, we can all just enable/disable the feature as desired.

You guys rock. Please keep making Windows Terminal great!

## Summary of the Pull Request ![preview-ats-000](https://user-images.githubusercontent.com/18356694/94801728-18302a00-03ac-11eb-851d-760b92ebb46f.gif) This PR enables the ATS to display the active tab as the user navigates the tab switcher. We do this by dispatching the tab switch actions as the user navigates the menu, and manually _not_ focusing the new tab when the tab switcher is open. ## References * #6732 - original tab switcher PR * #6689 - That's a more involved, generic version of this, but this PR will be enough to stop most of the complaints hopefully ## PR Checklist * [x] Closes #7409 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Opened tabs, tabbed through the menu, verified that it did what I'd expect

## Summary of the Pull Request ![preview-ats-000](https://user-images.githubusercontent.com/18356694/94801728-18302a00-03ac-11eb-851d-760b92ebb46f.gif) This PR enables the ATS to display the active tab as the user navigates the tab switcher. We do this by dispatching the tab switch actions as the user navigates the menu, and manually _not_ focusing the new tab when the tab switcher is open. ## References * #6732 - original tab switcher PR * #6689 - That's a more involved, generic version of this, but this PR will be enough to stop most of the complaints hopefully ## PR Checklist * [x] Closes #7409 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Opened tabs, tabbed through the menu, verified that it did what I'd expect (cherry picked from commit 22887d7)

lets take it all and move it here

b43e32b

Carlos Zamora (carlos-zamora) suggested changes Jun 30, 2020

View reviewed changes

ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 30, 2020

Leon Liang (leonMSFT) added 2 commits July 1, 2020 12:51

explicitly set command palette mode on handler call

f3b0106

change TerminalApp::AnchorKey to VirtualKey

c7e1f0d

Leon Liang (leonMSFT) added 9 commits July 6, 2020 10:48

a couple of comments, fixing ordering once again

b5e2c77

lets hardcode shift as the 'backwards' modifier key for now

fbff9cf

ok well i have icons now but it crash but that's progress right

8824323

on second thought i'm going to leave this icon thing for later

4414bfe

resolving merge conflicts from master

83884c0

yeah just casually miss a whole file when merging

5462e36

reverting some stuff that shouldn't have changed

cd828f1

try and try again

9d527a6

pls

33cfc86

Leon Liang (leonMSFT) added 3 commits July 8, 2020 14:03

fix the ordering when filtering

87a8174

added observables to both Command and Tab

a204667

adding default font icons to commands with no specified icons, added …

2b17953

…tab icons

Mike Griese (zadjii-msft) requested changes Jul 9, 2020

View reviewed changes

ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 9, 2020

Leon Liang (leonMSFT) added 2 commits July 10, 2020 11:15

convert iconstring to iconsource

f57ce5c

steal griese's commandsToFilter function huehue

9128fd9

Dustin L. Howett (DHowett) removed their assignment Aug 7, 2020

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 10, 2020

Leon Liang (leonMSFT) added 3 commits August 10, 2020 11:22

pr comments, do the thing on the UI thread

04fa2cf

merge from master

7271bd6

bot needs to go have a timeout

d30f8df

Leon Liang (leonMSFT) assigned Dustin L. Howett (DHowett) Aug 10, 2020

Leon Liang (leonMSFT) mentioned this pull request Aug 10, 2020

Add keybinding docs for tabSwitcher MicrosoftDocs/terminal#107

Merged

Carlos Zamora (carlos-zamora) approved these changes Aug 10, 2020

View reviewed changes

Dustin L. Howett (DHowett) approved these changes Aug 10, 2020

View reviewed changes

OMG SORRY ONE LAST THINGGG

ec289b6

Mike Griese (zadjii-msft) added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 11, 2020

ghost merged commit b07c1e4 into master Aug 11, 2020

ghost deleted the dev/lelian/ats-take2 branch August 11, 2020 14:03

Dustin L. Howett (DHowett) mentioned this pull request Aug 12, 2020

Command palette no longer shows "no matching commands" #7254

Closed

Kayla Cinnamon (cinnamon-msft) mentioned this pull request Aug 20, 2020

Document 1.3 release features MicrosoftDocs/terminal#117

Closed

14 tasks done

Mike Griese (zadjii-msft) mentioned this pull request Aug 21, 2020

Add icons to commands in the Command Palette #7368

Merged

2 of 3 tasks

ghost mentioned this pull request Aug 26, 2020

Feature Request: An advanced tab switcher #1502

Closed

Mike Griese (zadjii-msft) mentioned this pull request Oct 1, 2020

Preview tab switching with the ATS #7796

Merged

2 of 3 tasks

Don-Vito mentioned this pull request Dec 10, 2020

Launching "Find" from Command Palette doesn't focus the search box #6662

Closed

Mike Griese (zadjii-msft) mentioned this pull request Jul 27, 2023

Add a "search tab" feature #15772

Closed

Mike Griese (zadjii-msft) mentioned this pull request May 11, 2026

Feature request: Enable customization for tabs on bottom/right/left #835

Open

This pull request was closed.

Conversation

Leon Liang (leonMSFT) commented Jun 30, 2020 • edited by DHowett Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

References

Uh oh!

Carlos Zamora (carlos-zamora) left a comment

Choose a reason for hiding this comment

UX Issues

Command Palette Inaccessible

Going Backwards on the Tab Switcher

"Search" box

Tab Switcher Results Order

Rearranging Tabs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

komawoyo commented Jul 5, 2020

Uh oh!

Leon Liang (leonMSFT) commented Jul 9, 2020

Uh oh!

Mike Griese (zadjii-msft) commented Jul 9, 2020

Uh oh!

Mike Griese (zadjii-msft) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mike Griese (zadjii-msft) commented Aug 10, 2020

Uh oh!

Deleted user (ghost) commented Aug 11, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Deleted user (ghost) commented Aug 26, 2020

Uh oh!

Russell R. Riker (Dr-WaSaBi) commented Sep 1, 2020

Uh oh!

Simon Ratner (simonratner) commented Sep 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pete DeBiase (pete-debiase) commented Sep 20, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Leon Liang (leonMSFT) commented Jun 30, 2020 •

edited by DHowett

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Simon Ratner (simonratner) commented Sep 4, 2020 •

edited

Loading