Repository navigation
Enable fullscreen mode - #3408
Merged
Mike Griese (zadjii-msft) merged 14 commits intoNov 5, 2019
Merged
Conversation
Mike Griese (zadjii-msft)
added
Area-UserInterface
Michael Niksa (miniksa)
suggested changes
Nov 1, 2019
ghost
added
the
Needs-Author-Feedback
Carlos Zamora (carlos-zamora)
approved these changes
Nov 1, 2019
Carlos Zamora (carlos-zamora)
left a comment
Carlos Zamora (carlos-zamora)
left a comment
There was a problem hiding this comment.
Michael beat me to most/all of these. Mostly comment nits on my end though.
ghost
removed
the
Needs-Author-Feedback
…reen-but-on-master
…reen-but-on-master # Conflicts: # src/cascadia/TerminalApp/TerminalPage.h
Michael Niksa (miniksa)
approved these changes
Nov 4, 2019
Member
Author
|
(I'm holding this for #3394, because that PR is great, and I'll deal with the merge conflicts myself) |
# Conflicts: # src/cascadia/WindowsTerminal/IslandWindow.h # src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp # src/cascadia/WindowsTerminal/NonClientIslandWindow.h
3 of 9 tasks
|
🎉 Handy links: |
ghost
mentioned this pull request
Mike Griese (zadjii-msft)
deleted the
dev/migrie/f/fullscreen-but-on-master
branch
January 31, 2020 14:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Enables the
toggleFullscreenaction to be able to enter fullscreen mode, bound by default to alt+enter.The action is bubbled up to the WindowsTerminal (Win32) layer, where the window resizes itself to take the entire size of the monitor.
This largely reuses code from conhost. Conhost already had a fullscreen mode, so I figured I might as well re-use that.
References
Unfortunately there are still very thin borders around the window when the NonClientIslandWindow is fullscreened. I think I know where the problem is. However, that area of code is about to get a massive overhaul with #3064, so I didn't want to necessarily make it worse right now.
A follow up should be filed to add support for "Always show / reveal / never show tabs in fullscreen mode". Currently, the only mode is "never show tabs".
Additionally, some of this code (particularily re:drawing the nonclient area) could be re-used for #2238.
PR Checklist
showTabsInTitlebarset to true, the window border is still visible #3411Validation Steps Performed