You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
schema: Allow verbose no-argument actions in the settings schema - #20430
The settings schema only accepted the short form because FullCommand.command
had no object branch for actions without arguments.
This adds a strict NoArgsAction definition for the 39 argument-free actions.
It also connects the existing AddMarkAction, SetFocusModeAction, SetFullScreenAction, and SetMaximizedAction definitions, which were not
referenced by FullCommand.command.
Validation Steps Performed
Validated doc/cascadia/profiles.schema.json with PowerShell 7.6 Test-Json:
All 39 no-argument actions validate in verbose form.
Existing short forms still validate.
Empty and populated forms of the four optional-argument actions validate.
Dustin L. Howett (DHowett)
changed the title
Allow verbose no-argument actions in the settings schema
schema: Allow verbose no-argument actions in the settings schema
Jul 16, 2026
Dustin L. Howett (@DHowett) Quick status update: I re-checked this against current main. The diff still applies cleanly, and the verbose no-argument forms ({ "action": "toggleAlwaysOnTop" }, { "action": "addMark" }, etc.) are still rejected there without this change. I'm happy to rebase if that helps review.
While doing that, I cross-referenced ALL_SHORTCUT_ACTIONS in AllShortcutActions.h against the ShortcutActionName enum in the schema. These actions are accepted by Terminal but are missing from the schema entirely, so even the short form ("command": "restartConnection") is flagged as invalid:
restartConnection
showContextMenu
toggleBroadcastInput
quickFix
enableReadOnlyMode
disableReadOnlyMode
There are also three that might be intentionally left out: breakIntoDebugger, debugTerminalCwd, and experimental.openScratchpad.
I'd like to keep this PR scoped to #11332, but I can follow up with:
A small PR that adds the missing actions to the enum (and to NoArgsAction once this lands).
Optionally, a check that compares the schema's action list against AllShortcutActions.h, so this list doesn't drift again. I'm not sure whether you'd want that as a script under tools/ or as part of CI, or at all.
Let me know which of these would be useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Area-SchemaThings that have to do with the json schema.Issue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
FullCommand.command.References and Relevant Issues
Closes #11332
Detailed Description of the Pull Request / Additional comments
Windows Terminal accepts both of these forms:
{ "command": "toggleAlwaysOnTop" } { "command": { "action": "toggleAlwaysOnTop" } }The settings schema only accepted the short form because
FullCommand.commandhad no object branch for actions without arguments.
This adds a strict
NoArgsActiondefinition for the 39 argument-free actions.It also connects the existing
AddMarkAction,SetFocusModeAction,SetFullScreenAction, andSetMaximizedActiondefinitions, which were notreferenced by
FullCommand.command.Validation Steps Performed
Validated
doc/cascadia/profiles.schema.jsonwith PowerShell 7.6Test-Json:git diff --checkpasses.PR Checklist