Repository navigation
Schema does not allow actions without arguments in verbose form #11332
Description
Windows Terminal version (or Windows build number)
1.9.1942.0
Other Software
No response
Steps to reproduce
Bind any 'shortcut action' using the following syntax:
{
"command": {
"action": "toggleAlwaysOnTop" // Most of the toggle actions qualify
},
"keys": "ctrl+alt+shift+§" // Any key combination
}
Expected Behavior
The schema should allow this, it's a working syntax.
Actual Behavior
It's considered invalid, with two problems:
-
Missing property "delta".
Arguments corresponding to an Adjust Font Size Action -
String does not match the pattern of "adjustFontSize".
Reacted by Paciupa
Activity
elsaco commentedon Sep 26, 2021
Sean Jacobs (@Sophismata) please try
{ "command": "toggleAlwaysOnTop", "keys": "ctrl+alt+shift+§" }Sophismata commentedon Sep 27, 2021
Elsaco (@elsaco)
That will work, but it doesn't stop the schema being in error. Either:
zadjii-msft commentedon Sep 27, 2021
Yea, sure this is a bug in the schema I suppose.
elsaco commentedon Sep 27, 2021
Sean Jacobs (@Sophismata) command is missing argument(s):
{ "command": { "action": "toggleAlwaysOnTop" }, "keys": "ctrl+alt+shift+§" }It should be something like:
{ "command": { "action": "toggleAlwaysOnTop", "argument": "some_value_here" }, "keys": "ctrl+alt+shift+§" }I'm not sure "toggleAlwaysOnTop" takes any arguments.
zadjii-msft commentedon Sep 27, 2021
Technically,
{ "command": { "action": "toggleAlwaysOnTop" }, "keys": "ctrl+alt+shift+§" }is valid, it's the same as{ "command": "toggleAlwaysOnTop", "keys": "ctrl+alt+shift+§" }. The bug here is that the schema doesn't validate that as valid. you don't need the long form for anything without args, but it will work with the Terminal.Sophismata commentedon Sep 28, 2021
I went over the schema last night, found the issue (and also why the error reporting is off, it's because
AdjustFontSizeis the first seemingly-valid schema for the verbose form action).I'll fork and submit a PR if people are fine with that.
Sadly the language being used for command / action is really inconsistent. The actions array holds commands, which themselves contain either actions or additional commands.
Edit: actually there are some more schema bugs lurking around. I'll take a look at the other schema issues and see what I can hit.
DanPinGF commentedon Dec 9, 2021
Try adding /logs
Weichenleeeee123 commentedon Jul 16, 2026
I can reproduce this on the current main schema: the short no-argument form validates, while the equivalent verbose object form does not. I couldn't find an assignee, linked PR, or follow-up to the 2021 discussion, so I'd like to work on a narrow schema fix with a regression check.