Repository navigation
Switch WinUI to the Windows 11 styles - #12241
Merged
4 commits merged intoJan 27, 2022
Merged
4 commits merged into
4 commits merged into
Conversation
Member
|
Mike Griese (zadjii-msft)
added
the
Needs-Discussion
PankajBhojwani
commented
Jan 25, 2022
4 tasks done
Member
|
How does it look overall? Should we merge and test in post? |
Contributor
Author
I like this idea, the visual issues we've found so far have been fixed getting it in will help us find more (if any) faster |
Dustin L. Howett (DHowett)
changed the title
Member
|
|
Member
Ship, file, fix. :) |
Dustin L. Howett (DHowett)
approved these changes
Jan 26, 2022
Dustin L. Howett (DHowett)
added
the
AutoMerge
|
Hello Dustin L. Howett (@DHowett)! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Mike Griese (zadjii-msft)
approved these changes
Jan 27, 2022
ghost
deleted the
dev/pabhoj/xaml_version_2
branch
January 27, 2022 13:26
ghost
pushed a commit
that referenced
this pull request
Jan 27, 2022
Turns out, this bug only repros in Controls version 2. I'm not sure why, but it didn't repro only on main. So this fix does nothing until #11720 merges. This PR prevents us from setting properties on the paste warning dialog unless we actually need to paste. 5f9c551 proves that settings these properties is what would cause the bug in the first place. I went a step further and cleaned this up a bit. This was always a little weird, having to get the `BracketedPasteEnabled` for the active control on the UI thread before we actually display the warning. In the post-#5000 future where going back to the control like this would be a x-proc hop, I figured I should just skip that entirely and plumb the `BracketedPaste` state out in the initial request. * [x] Closes #12202 * [x] I work here * [x] No tests, but there's not a great place for a test like this * [x] Doesn't affect docs See also: #12241 which would introduce #12202 on its own.
Mike Griese (zadjii-msft)
removed
the
Needs-Discussion
14 of 17 tasks
8 of 12 tasks
Mike Griese (zadjii-msft)
pushed a commit
that referenced
this pull request
Mar 3, 2022
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.