Skip to content

Miscellaneous Settings UI nits #11353

Closed

Description

discovered in the 1.12 bug bash on 9/28, but these aren't 1.12 blocking issues

  • Navigation View Sidebar] the names of the new VS names don't fit (nor do they get a tooltip)
  • [Actions page] there's an unnamed action (appears as Microsoft.Terminal.Settings.Editor.KeyBinding). After adding it, when clicking "Add new" again or saving, it disappears. Saving it also doesn't appear in the JSON.
  • [Appearance tab of a profile] Background image path does not appear in the text box
  • [Appearance tab of a profile] "Reset to inherited value" button for the padding slider needs to be hit twice to make the button go away
  • image Needs padding under it,
  • image Button should have "Delete" after the icon
  • "Intense Text Style" Also lowercase t and s on text style
  • The settings icon in the tab should be updated to the new gear icon (used in the Open JSON file nav item)
    image

The following were noted after #12241 merged

Activity

  1. added
    Help WantedWe encourage anyone to jump in on these.
    Issue-TaskIt's a feature request, but it doesn't really need a major design.
    on Sep 28, 2021
  2. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Sep 28, 2021
  3. ghost added a commit that references this issue on Sep 29, 2021
  4. ghost added a commit that references this issue on Oct 6, 2021
  5. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Oct 15, 2021
  6. 6 remaining items

  7. ghost added a commit that references this issue on Feb 11, 2022
  8. ghost added a commit that references this issue on Feb 11, 2022
  9. ghost added
    In-PRThis issue has a related PR
    on Feb 11, 2022
  10. ghost closed this as completedin #12469on Feb 11, 2022
  11. ghost added a commit that references this issue on Feb 11, 2022
  12. ghost removed
    In-PRThis issue has a related PR
    on Feb 11, 2022
  13. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-SettingsUIAnything specific to the SUIHelp WantedWe encourage anyone to jump in on these.Issue-TaskIt's a feature request, but it doesn't really need a major design.Priority-3A description (P3)Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions