Update Actions, Color Schemes pages in SUI to match Controlsv2 style #12388

Activity

1. ghost added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Feb 5, 2022
2. ghost added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Feb 5, 2022
3. j4james commented on Feb 6, 2022

   

   James Holderness (j4james)

   on Feb 6, 2022

   Collaborator

   More actions

   I also think the alignment feels wrong on the Color schemes and Actions pages. The contents of those pages is centered, but the titles are way off to the left. I'm assuming that's intended match the title position on the other pages, but then I'd expect the content to be similarly left aligned rather than centered. As it is, it just looks broken to me.
4. zadjii-msft commented on Feb 7, 2022

   

   Mike Griese (zadjii-msft)

   on Feb 7, 2022

   Member

   More actions

   This might already be fixed in #12374, PankajBhojwani to confirm the bit about the ColorSchemes and Actions pages too
5. Mike Griese (zadjii-msft)

   added

   Area-SettingsUIAnything specific to the SUIAnything specific to the SUI

   Priority-3A description (P3)A description (P3)

   Product-TerminalThe new Windows Terminal.The new Windows Terminal.

   zPreview-Service-Queued-1.13

   on Feb 7, 2022
6. Mike Griese (zadjii-msft)

   added this to the Terminal v1.14 milestone on Feb 7, 2022
7. PankajBhojwani commented on Feb 7, 2022

   

   PankajBhojwani

   on Feb 7, 2022

   Contributor

   More actions

   The disclaimer text on the Rendering and Defaults pages is fixed in #12374. As for the ColorSchemes and Actions pages, those pages have not yet been updated to the new style - once we get to updating those pages the alignment will be fixed. (We have to do some amount of backend work first before we can get to updating those pages - mainly implementing the MVVM pattern there).

   👍React with 👍1Reacted by James Holderness
8. Mike Griese (zadjii-msft)

   removed

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Feb 8, 2022
9. Mike Griese (zadjii-msft)

   changed the title [-]SUI text alignment[/-] [+]Update Actions, Color Schemes pages in SUI to match Controlsv2 style[/+] on Mar 10, 2022
10. Mike Griese (zadjii-msft)

    removed

    zPreview-Service-Queued-1.13

    on Mar 10, 2022
11. Mike Griese (zadjii-msft)

    modified the milestones: Terminal v1.14, 22H1 on Mar 10, 2022
12. Mike Griese (zadjii-msft)

    added

    Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.

    on Mar 10, 2022
13. ghost removed

    Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

    on Mar 10, 2022
14. zadjii-msft commented on Mar 10, 2022

    

    Mike Griese (zadjii-msft)

    on Mar 10, 2022

    Member

    More actions

    Repurposing this to track the rejuv for those pages, and retitling. We've been using this to track that work anyways, the title may as well match.

    Punted out of 1.14 because we don't have runway for the refactor required here.

    ---

    Greatly trimmed Teams chat regarding design:

    

    Then the expander gives a place for action args once we get those into the SUI

    so expanded, that's got the action dropdown and the keybinding editor, and the.... delete button?

    Yeah I'm thinking like this
    

    Then since it's a text box inside the expander, it should show up on the top of the expander itself

    okay so the expander content would basically just be what we have for the action now
15. Mike Griese (zadjii-msft)

    added

    Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Complex enough to require an in depth planning process and actual budgeted, scheduled work.

    Priority-1A description (P1)A description (P1)

    and removed

    Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.

    Priority-3A description (P3)A description (P3)

    on Jun 13, 2022
16. zadjii-msft commented on Jun 15, 2022

    

    Mike Griese (zadjii-msft)

    on Jun 15, 2022

    Member

    More actions

    See also

    • People think the Color Scheme editor will change the current colors #9775
17. Mike Griese (zadjii-msft)

    modified the milestones: 22H1, Terminal v1.16 on Jun 22, 2022
18. Mike Griese (zadjii-msft)

    modified the milestones: Terminal v1.16, Terminal v1.17 on Aug 1, 2022
19. Mike Griese (zadjii-msft)

    modified the milestones: Terminal v1.17, Backlog on Jan 24, 2023