Skip to content

People think the Color Scheme editor will change the current colors #9775

Closed

Description

Windows Terminal version (or Windows build number)

10.0.21354 (Dev)

Other Software

No response

Steps to reproduce

  1. Launch Terminal
  2. Open Settings
  3. Color Schemes
  4. Select another color scheme from combo
  5. Click to Save
  6. Reopen Settings -> Color Scheme didn't applied

Expected Behavior

No response

Actual Behavior

Color Scheme.

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Apr 11, 2021
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Apr 11, 2021
  3. DHowett commented on Apr 11, 2021

    @DHowett
    Member

    What terminal version.

  4. sphars commented on Apr 14, 2021

    @sphars

    I'm seeing this issue as well. Just updated to v1.7.1033.0 (the new release). No matter what I try, I can't seem to apply a color scheme using the new Settings UI. It gets reset back to Campbell on each relaunch.

    Edit: This issue with with the default color scheme. Changing the scheme under individual profiles does apply the scheme properly to that profile.

    Edit 2: Looking at recent commits, looks like it might be fixed in #9764

  5. miwojc commented on Apr 16, 2021

    @miwojc

    Same issue. Version: 1.7.1033.0
    Edit: Also would be nice to be able to get to settings json file with keyboard shortcut (as before graphical UI ctr ,) because graphical UI doesn't have all the options settings json has. thanks!

  6. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Apr 16, 2021
  7. zadjii-msft commented on Apr 20, 2021

    @zadjii-msft
    Member

    Wait HOLD UP.

    Are you going to the "Color Schemes" page
    image

    or are you changing the "color scheme" of a given profile:
    image

    The first page is used for editing the color scheme itself. The second is for changing the appearance of the selected profile. The dropdown on the Color Schemes page is just used for selecting which scheme you want to edit. It doesn't apply that scheme to any profiles.

  8. sphars commented on Apr 20, 2021

    @sphars

    Mike Griese (@zadjii-msft) You're totally correct, now that I've taken a look into that. Gotta say though, it's definitely confusing on first use. I would assume that the Color schemes page is for selecting a default color scheme for all profiles (and yes you could edit the colors as well). Then you can go into individual profiles and override to a different color scheme.

    Perhaps it just needs some some clarification on what the Coloring schemes page does. Maybe selecting a default color scheme would be better suited under Appearance (if setting a default color scheme is a goal).

  9. miwojc commented on Apr 20, 2021

    @miwojc

    Is it possible to change default theme that would apply to all profiles like via settings.json?

  10. 29 remaining items

  11. ghost added
    In-PRThis issue has a related PR
    on Aug 1, 2022
  12. ghost removed
    In-PRThis issue has a related PR
    on Aug 25, 2022
  13. zadjii-msft commented on Aug 29, 2022

    @zadjii-msft
    Member

    Punting this for a release, since we feel like this wasn't wholly addressed in #13269

  14. ghost added
    In-PRThis issue has a related PR
    on Aug 31, 2022
  15. added a commit that references this issue on Aug 31, 2022
    7076613
  16. ghost removed
    In-PRThis issue has a related PR
    on Aug 31, 2022
  17. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-SettingsUIAnything specific to the SUIIssue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Priority-2A description (P2)Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions