Merged
Conversation
daprilik
reviewed
Nov 10, 2022
Contributor
daprilik
left a comment
daprilik
left a comment
There was a problem hiding this comment.
Broad strokes seem good, though I had a few questions to resolve before smashing that approve button
Co-authored-by: Daniel Prilik <71350465+daprilik@users.noreply.github.com>
daprilik
approved these changes
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is perhaps an over-designed error type, but it provides enough information to figure out why the conversion failed, which can help the programmer fix it.
This PR also includes #20, so review that first and I'll merge that one and rebase this one before merging it.
It would be nice to add a
impl std::error::Error for IntoStackFutureError, but for now we are ano_stdcrate and I wasn't sure adding ano_stdfeature would be worth it just for that impl. I think the plan is for theErrortrait to become part of core someday, so we could just wait until then.