Make StackFuture::from fail statically if the future doesn't fit#20
Merged
eholk merged 4 commits intomicrosoft:mainfrom Nov 10, 2022
Merged
Make StackFuture::from fail statically if the future doesn't fit#20eholk merged 4 commits intomicrosoft:mainfrom
eholk merged 4 commits intomicrosoft:mainfrom
Conversation
Merged
Contributor
Author
|
Weird that the static check isn't working on miri. I wonder if this is a bug around const evaluation with miri? |
daprilik
reviewed
Nov 9, 2022
eholk
force-pushed
the
static-size-check
branch
from
79eb825 to
9cec300
Compare
Contributor
Author
I asked about this on Zulip. It seems like what's probably going on is that the compilation failure happens post-monomorphization while Miri runs pre-monomorphization. If we remove the That makes me feel okay about adding a Miri-specific workaround for those tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @jstarks for the suggestion of how to do this!
This also bumps the version in
Cargo.tomlto0.3.0since it's a breaking change now thatStackFuture::fromwill fail to compile in cases where it would have panicked at runtime.