Support non-default negative axis value and intuitive data type combination for OneHot op - #1732
Merged
Merged
Conversation
…nation for OneHot op (#1317) * Handle nondefault negative axis value * Support more intuitive data types for this op
Hariharan Seshadri (hariharans29)
requested a review
from a team
as a code owner
August 29, 2019 23:48
Dwayne Robinson (fdwr)
approved these changes
Aug 30, 2019
Dwayne Robinson (fdwr)
left a comment
Dwayne Robinson (fdwr)
left a comment
Contributor
There was a problem hiding this comment.
Thanks Hari.
George Wu (jywu-mysoft)
approved these changes
Sep 4, 2019
Hector Li (HectorSVC)
approved these changes
Sep 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle nondefault negative axis value
Support more intuitive data types for this op