Support non-default negative axis value and intuitive data type combination for OneHot op - #1317
Merged
Merged
Conversation
Hariharan Seshadri (hariharans29)
requested a review
from a team
as a code owner
June 29, 2019 00:20
Member
Author
Contributor
|
Is this behavior documented in the spec? If not, can you document it? |
Pranav Sharma (pranavsharma)
approved these changes
Jun 29, 2019
Member
Author
This a good suggestion. But this behavior is implicitly understood and expected of all ONNX ops that have an It might be worthwhile to state this just once somewhere in ONNX as opposed to adding one line for this op (and every other op that's missing the behavior explicitly) |
Hariharan Seshadri (hariharans29)
added a commit
that referenced
this pull request
Aug 29, 2019
…nation for OneHot op (#1317) * Handle nondefault negative axis value * Support more intuitive data types for this op
Dmitri Smirnov (yuslepukhin)
pushed a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This change tries to resolve 2 open issues regarding the OneHot operator:
#1313 : Treat (non-default) negative axis value like how any other ONNX operator does
#1314 : Support a more intuitive data type combination for this operator
Motivation and Context
Resolve #1313 and #1314