Update to latest EsrpClientTool task and allow version override for testing#916
Merged
Conversation
Update the EsrpClientTool installer task from v4 to v5. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Allow Git version override at queue time. This skips the tag resolution to determine the Git version. Since this produces a build from an untagged commit, GitHub publishing will be skipped if set. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
mjcheetham
commented
May 15, 2026
| displayName: 'Enable GitHub release publishing' | ||
| - name: 'versionOverride' | ||
| type: string | ||
| default: '-' |
Member
Author
There was a problem hiding this comment.
We cannot use empty string '' because Azure Pipelines treats this as not being set, and then without a default this becomes a required property! Great... Use '-' as a sentinel value for 'not set'.
mjcheetham
commented
May 15, 2026
|
|
||
| steps: | ||
| - task: EsrpClientTool@4 | ||
| - task: EsrpClientTool@5 |
Member
Author
There was a problem hiding this comment.
This installs the latest 2.x of the esrpclient.exe which is about 25% faster when submitting files for signing!
mjcheetham
changed the title
dscho
approved these changes
May 15, 2026
Member
Author
|
Bypassing CI checks - the failures were flakes in the GitHub workflows; totally unrelated to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task version 4 was using an out of date Node.JS version. Version 5 is the latest.
Test run of the pipeline works.
Whilst we're at it, let's add a way to override the Git version so we can test without pushing an annotated tag. Untagged builds cannot publish to GitHub.
Builds with the override show like this:
