[release/13.5] Fix deprecated Homebrew cask DSL usage - #20119
Jose Perez Rodriguez (joperezr) merged 1 commit into
Conversation
Co-authored-by: James Newton-King <james@newtonking.com> (cherry picked from commit 12847d4) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> # Conflicts: # .github/workflows/homebrew-validate-release.yml # docs/release-process.md # eng/homebrew/README.md
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20119Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20119" |
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 2 / 100 test projects · 3 jobs, from 5 changed files. Selected test projects (2 / 100)
Selected jobs (3)
How these were chosen — grouped by what changed📄 📄 📄 📄 🧪 Job reasons
Selection computed for commit |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation and regression coverage are sound; remaining feedback concerns minor inaccuracies in the validation rationale.
Review tier: Balanced
Findings: 2
Open findings (2)
What changed in this PR
Backports Homebrew 6 compatibility fixes to release/13.5 while preserving release notarization validation.
Changes:
- Migrates the cask template to current Homebrew DSL.
- Updates audit flags and adds explicit notarization verification.
- Updates release documentation and regression tests.
| File | Description |
|---|---|
eng/homebrew/aspire.rb.template |
Updates deprecated cask DSL. |
eng/homebrew/dogfood.sh |
Simplifies local URL rewriting. |
eng/homebrew/validate-cask-artifact.sh |
Revises audits and verifies notarization. |
eng/homebrew/README.md |
Documents validation modes. |
eng/pipelines/release-publish-nuget.yml |
Updates release-pipeline comments. |
docs/release-process.md |
Documents the notarization gate. |
tests/Aspire.Acquisition.Tests/Scripts/PRScriptInstallerModeTests.cs |
Covers audit and notarization behavior. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
9c1b401
into
release/13.5
|
✅ No documentation update needed. Step 5 branch taken: This PR is a backport of #19965 to Triggered signals (2, both from No documentation PR was drafted. |

Description
Backport of #19965 to
release/13.5, cherry-picked from12847d472bd65282485fd102d449077e0bd66ff3.Homebrew 6.x rejects the deprecated
verified:cask URL parameter, blocking Homebrew validation on release-branch builds (including #20094 and #20110). This preserves the complete source fix: removeverified:, migratepostflight/File.writetopostflight_steps/write_file, simplify dogfood URL rewriting, and remove obsoletebrew audit --signing/--no-signingarguments.Conflict resolutions
.github/workflows/homebrew-validate-release.yml; retain release/13.5's Azure DevOpsHomebrewValidateJoband update both relevant pipeline comments.docs/release-process.mdandeng/homebrew/README.mdusing the release branch's existing orchestration, documenting the updated audit and explicit notarization gate without importing main's release-process migration.HomebrewValidateJobcomment.Security considerations
Preserves release-binary signature/notarization validation explicitly with
codesign --verify -R=notarized --check-notarizationon the installed Caskroom binary. Homebrew no longer runs its signing audit automatically for our temporary third-party tap. A failed notarization check remains fatal and invokes the existing uninstall/cleanup path. Regression coverage for invocation and failure cleanup is included; actual macOS verification was not run on this Windows host.Fixes # (issue)
Customer Impact
Unblocks Homebrew cask preparation/validation for release/13.5 with current Homebrew, while preserving install-channel metadata and the release notarization gate. No public API changes.
Testing
bd4a8e2efccc86a00ba9ff0df890a326f0318146.PRScriptInstallerModeTests: 11 Windows-compatible tests passed, 0 failed.bash -npassed fordogfood.sh,validate-cask-artifact.sh, andprepare-cask-artifact.sh.git diff --checkpassed.Risk
Low: scoped to Homebrew packaging/validation, related tests, and documentation. Existing release orchestration and cleanup behavior are retained. Real Homebrew/macOS execution remains the principal validation gap.
Regression?
Compatibility regression with current Homebrew: release PR #19998 passed September 9, while #20094 and #20110 failed September 13–14 on the deprecated
verifiedparameter. No specific Aspire-introduced regression has been identified.Checklist
<remarks />and<code />elements on your triple slash comments?