Fix deprecated Homebrew cask DSL usage - #19965
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19965Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19965" |
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently adopt supported Homebrew APIs, preserve validation behavior, and include focused regression coverage.
Pull request overview
Updates Homebrew cask generation and validation for Homebrew 6.x compatibility.
Changes:
- Replaces deprecated
verified:andpostflightDSL usage. - Removes obsolete signing audit flags.
- Updates tests and documentation accordingly.
File summaries
| File | Description |
|---|---|
eng/homebrew/aspire.rb.template |
Uses current cask DSL. |
eng/homebrew/dogfood.sh |
Simplifies one-line URL rewriting. |
eng/homebrew/validate-cask-artifact.sh |
Removes obsolete audit flags. |
eng/homebrew/README.md |
Updates validation documentation. |
docs/release-process.md |
Updates release audit commands. |
.github/workflows/homebrew-validate-release.yml |
Corrects workflow documentation. |
tests/Aspire.Acquisition.Tests/Scripts/PRScriptInstallerModeTests.cs |
Adds regression assertions for generated DSL and audit arguments. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
Added follow-up commit be34a06 to preserve release-binary signing validation. During a security-focused review, I found that current Homebrew disables the The follow-up now:
Local validation: Git Bash syntax check passed, |
Remove deprecated URL verification and postflight syntax, update Homebrew validation flags, and refresh related tests and documentation.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
be34a06 to
7ec8949
Compare
|
🔍 CI Failure Analysis: Transient Infrastructure Failure The CI build failed due to transient infrastructure issues. Failed jobs:
If a rerun was not already requested automatically, visit the workflow run page to rerun the failed jobs manually. |
|
/backport to release/13.5 |
|
Started backporting to |
|
Jose Perez Rodriguez (@joperezr) backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix deprecated Homebrew cask DSL usage
Using index info to reconstruct a base tree...
A .github/workflows/homebrew-validate-release.yml
M docs/release-process.md
M eng/homebrew/README.md
M eng/homebrew/validate-cask-artifact.sh
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): .github/workflows/homebrew-validate-release.yml deleted in HEAD and modified in Fix deprecated Homebrew cask DSL usage. Version Fix deprecated Homebrew cask DSL usage of .github/workflows/homebrew-validate-release.yml left in tree.
Auto-merging docs/release-process.md
CONFLICT (content): Merge conflict in docs/release-process.md
Auto-merging eng/homebrew/README.md
CONFLICT (content): Merge conflict in eng/homebrew/README.md
Auto-merging eng/homebrew/validate-cask-artifact.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Fix deprecated Homebrew cask DSL usage
Error: The process '/usr/bin/git' failed with exit code 128 |
Co-authored-by: James Newton-King <james@newtonking.com> (cherry picked from commit 12847d4) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> # Conflicts: # .github/workflows/homebrew-validate-release.yml # docs/release-process.md # eng/homebrew/README.md Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com>
Description
Homebrew 6.x reports deprecation warnings for the Aspire cask because it uses the legacy
verified:URL parameter andpostflightstanza. This updates the generated cask template to use Homebrew's default URL verification behavior andpostflight_steps/write_file, sobrew updateand cask validation no longer emit those warnings.The Homebrew validation scripts, workflow documentation, and regression tests are updated to use the current
brew auditarguments without the removed--signingand--no-signingflags. Dogfood URL rewriting remains compatible with the updated one-line URL stanza.Validation completed:
brew style --caskpassed.brew test-bot --only-tap-syntaxpassed.brew audit --caskpassed against the generated cask.git diff --checkpassed.Fixes # (issue)
Notes
Output from terminal
Checklist
<remarks />and<code />elements on your triple slash comments?