Stabilize AppHost tree discovery E2E - #19276
Merged
Adam Ratzman (adamint) merged 1 commit intoAug 12, 2026
Merged
Adam Ratzman (adamint) merged 1 commit into
Adam Ratzman (adamint) merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 10fd3379-b660-428c-b696-27e8c03d6d3f
Adam Ratzman (adamint)
requested a review
from Ella Hathaway (ellahathaway)
as a code owner
August 12, 2026 04:51
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19276Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19276" |
Contributor
There was a problem hiding this comment.
Pull request overview
Stabilizes AppHost tree E2E synchronization by replacing transient loading-state polling with durable request markers.
Changes:
- Add marker-backed gates for fresh
psandlsrequests. - Assert the running AppHost remains visible while discovery is gated.
- Update regression checks for the new ordering.
Show a summary per file
| File | Description |
|---|---|
extension/src/test/e2eLaunchProfile.test.ts |
Validates durable gate usage and ordering. |
extension/src/test-e2e/helpers/fixtures.ts |
Adds request marker files and wait helpers. |
extension/src/test-e2e/appHostTree.e2e.test.ts |
Uses durable gates instead of transient loading state. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
Adam Ratzman (adamint)
enabled auto-merge (squash)
August 12, 2026 05:00
Mitch Denny (mitchdenny)
approved these changes
Aug 12, 2026
Contributor
|
The CI build contains both transient and non-transient failures. Failed jobs:
The CI will not be automatically rerun. Please review the failures above. |
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The AppHost tree E2E could time out while waiting to observe a transient repository loading state even though the running AppHost was already visible. An existing
describe --followupdate could clear that state between the test's polling intervals.This replaces the transient-state dependency with durable marker files that confirm the fresh
psandlsrequests have reached their gates. The test then verifies the intended behavior: the running AppHost remains visible before slow workspace discovery produces a candidate.Validation:
extension/build.shmainFixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?